-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): assert using span events instead of mocks #11856
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 1468 Passed, 0 Skipped, 25m 23.96s Total duration (12m 0s time saved) |
BenchmarksBenchmark execution time: 2025-01-09 18:58:32 Comparing candidate commit 76340ca in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
d0cc865
to
24b8c92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the one comment I left, this LGTM. Thanks for the thorough explanation! Also, feel free to ping for a final pass.
f39ac5c
to
047e147
Compare
63fa4e0
to
76340ca
Compare
Follow up of #11781 to further clean up LLMObs tests, specifically replacing potentially flaky LLMObs span writer mocks and assertions with the test LLMObsSpanWriter dummy class. Also clean up the
tests/llmobs/conftest.py
file which previously contained a ton of rarely used and sometimes redundant fixtures.Checklist
Reviewer Checklist