Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iast): taint flask request args and form #11883

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jan 9, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Jan 9, 2025

CODEOWNERS have been resolved as:

.github/workflows/system-tests.yml                                      @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_asm_request_context.py                                  @DataDog/asm-python
tests/contrib/flask/test_flask_appsec_iast.py                           @DataDog/asm-python

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: gnufede/APPSEC-56293-iast-flask-taint-http-request-parameter-name
Commit report: 9e4efe3
Test service: dd-trace-py

✅ 0 Failed, 87 Passed, 1468 Skipped, 3m 42.08s Total duration (35m 26.35s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-10 13:21:25

Comparing candidate commit 1b26e4c in PR branch gnufede/APPSEC-56293-iast-flask-taint-http-request-parameter-name with baseline commit 41fce6d in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 355 metrics, 0 unstable metrics.

scenario:iast_aspects-ljust_aspect

  • 🟥 execution_time [+1.117µs; +1.222µs] or [+8.029%; +8.784%]

@gnufede gnufede changed the title chore(iast): taint Flask ImmutableMultiDict keys chore(iast): taint Flask request args and form Jan 9, 2025
@gnufede gnufede changed the title chore(iast): taint Flask request args and form chore(iast): taint flask request args and form Jan 10, 2025
@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant