-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(serverless): force reimport of modules during serverless test #11888
base: main
Are you sure you want to change the base?
Conversation
|
Datadog ReportBranch report: ✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 38.31s Total duration (35m 39.08s time saved) |
BenchmarksBenchmark execution time: 2025-01-22 21:46:12 Comparing candidate commit 111226c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics. |
07c753d
to
6977fcd
Compare
6977fcd
to
ee55cae
Compare
Commit 12655ee removed the
@pytest.mark.subprocess()
from the serverless slow imports test. This effectively rendered the test useless asddtrace
and all required modules had already been imported in the parent process.Adding the subprocess mark back will ensure that the sys modules are fresh. We must still go through and delete entries because
@pytest.mark.subprocess()
relies onmultiprocessing
, so it must be removed so as to ensure it can be reimported if needed.Checklist
Reviewer Checklist