Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(serverless): force reimport of modules during serverless test #11888

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

purple4reina
Copy link
Contributor

@purple4reina purple4reina commented Jan 9, 2025

Commit 12655ee removed the @pytest.mark.subprocess() from the serverless slow imports test. This effectively rendered the test useless as ddtrace and all required modules had already been imported in the parent process.

Adding the subprocess mark back will ensure that the sys modules are fresh. We must still go through and delete entries because @pytest.mark.subprocess() relies on multiprocessing, so it must be removed so as to ensure it can be reimported if needed.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@purple4reina purple4reina requested a review from a team as a code owner January 9, 2025 22:11
Copy link
Contributor

github-actions bot commented Jan 9, 2025

CODEOWNERS have been resolved as:

.gitlab/tests.yml                                                       @DataDog/python-guild @DataDog/apm-core-python
tests/internal/test_serverless.py                                       @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 9, 2025

Datadog Report

Branch report: rey.abolofia/fix-sls-test
Commit report: 111226c
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 38.31s Total duration (35m 39.08s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-22 21:46:12

Comparing candidate commit 111226c in PR branch rey.abolofia/fix-sls-test with baseline commit 2f52abb in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@purple4reina purple4reina added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 10, 2025
@emmettbutler emmettbutler changed the title Force reimport of modules during serverless test. ci(serverless): force reimport of modules during serverless test Jan 10, 2025
@purple4reina purple4reina force-pushed the rey.abolofia/fix-sls-test branch from 07c753d to 6977fcd Compare January 10, 2025 20:58
@purple4reina purple4reina requested a review from a team as a code owner January 10, 2025 20:58
@purple4reina purple4reina force-pushed the rey.abolofia/fix-sls-test branch from 6977fcd to ee55cae Compare January 10, 2025 21:14
@purple4reina purple4reina enabled auto-merge (squash) January 22, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants