Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix bm test to reflect behavior of config for propagation #12049

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

ZStriker19
Copy link
Contributor

@ZStriker19 ZStriker19 commented Jan 23, 2025

This fixes the benchmarking test to reflect the config change made in this PR: #11925

It also updates the config behavior slightly since the removing of "none" propagation style at the end of the loop was repetitive since we were already excluding that value.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

benchmarks/http_propagation_extract/scenario.py                         @DataDog/apm-core-python
ddtrace/settings/config.py                                              @DataDog/python-guild @DataDog/apm-sdk-api-python

@ZStriker19 ZStriker19 added the changelog/no-changelog A changelog entry is not required for this PR. label Jan 23, 2025
@ZStriker19 ZStriker19 marked this pull request as ready for review January 23, 2025 17:18
@ZStriker19 ZStriker19 requested review from a team as code owners January 23, 2025 17:18
@ZStriker19 ZStriker19 enabled auto-merge (squash) January 23, 2025 17:21
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: zachg/chore_fix_prop_test
Commit report: b2247eb
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 45.19s Total duration (35m 42.76s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-23 18:04:38

Comparing candidate commit b2247eb in PR branch zachg/chore_fix_prop_test with baseline commit dc7037e in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 393 metrics, 2 unstable metrics.

scenario:httppropagationextract-none_propagation_style

  • 🟩 execution_time [-4.228µs; -4.183µs] or [-72.416%; -71.646%]

@emmettbutler emmettbutler changed the title chore: fix bm test to reflect behavior of config for propagation ci: fix bm test to reflect behavior of config for propagation Jan 24, 2025
@ZStriker19 ZStriker19 merged commit 1e97f99 into main Jan 24, 2025
693 of 694 checks passed
@ZStriker19 ZStriker19 deleted the zachg/chore_fix_prop_test branch January 24, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants