Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dogstatsd] hardcode filter metric #761

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Hardcodes a metric to be excluded

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@pr-commenter
Copy link

pr-commenter bot commented Nov 26, 2024

Benchmarks

Comparison

Benchmark execution time: 2024-12-20 19:54:34

Comparing candidate commit dbc8869 in PR branch jordan.gonzalez/hardcode-metric-filtering with baseline commit 9d898c9 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+2.833ms; +2.890ms] or [+4.849%; +4.946%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 543.817µs 545.579µs ± 1.211µs 545.214µs ± 0.459µs 545.786µs 548.305µs 549.677µs 551.266µs 1.11% 1.903 3.987 0.22% 0.086µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1814005.688op/s 1832924.305op/s ± 4052.322op/s 1834141.454op/s ± 1541.552op/s 1835493.494op/s 1836859.591op/s 1837304.549op/s 1838854.936op/s 0.26% -1.887 3.904 0.22% 286.542op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 474.852µs 475.856µs ± 0.324µs 475.857µs ± 0.220µs 476.080µs 476.391µs 476.503µs 476.718µs 0.18% -0.124 0.039 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2097677.584op/s 2101477.575op/s ± 1432.378op/s 2101471.080op/s ± 969.345op/s 2102394.002op/s 2104003.041op/s 2104637.508op/s 2105920.252op/s 0.21% 0.128 0.041 0.07% 101.284op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.525µs 194.939µs ± 0.185µs 194.959µs ± 0.123µs 195.051µs 195.220µs 195.339µs 195.556µs 0.31% 0.140 -0.026 0.09% 0.013µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5113619.237op/s 5129808.251op/s ± 4875.282op/s 5129296.055op/s ± 3238.827op/s 5133186.780op/s 5138058.170op/s 5140317.923op/s 5140716.981op/s 0.22% -0.135 -0.032 0.09% 344.735op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.039µs 47.897µs ± 0.305µs 47.970µs ± 0.201µs 48.121µs 48.293µs 48.340µs 48.467µs 1.04% -0.579 -0.646 0.63% 0.022µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20632656.627op/s 20879039.852op/s ± 133411.468op/s 20846273.221op/s ± 86885.850op/s 20970351.365op/s 21128883.185op/s 21159135.146op/s 21259020.363op/s 1.98% 0.598 -0.620 0.64% 9433.615op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 50.007µs 50.225µs ± 0.123µs 50.209µs ± 0.064µs 50.279µs 50.374µs 50.613µs 51.227µs 2.03% 3.155 21.502 0.24% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19521090.241op/s 19910580.574op/s ± 48442.477op/s 19916855.330op/s ± 25292.429op/s 19939919.864op/s 19971402.130op/s 19980739.508op/s 19997092.188op/s 0.40% -3.057 20.498 0.24% 3425.400op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [545.411µs; 545.747µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1832362.692op/s; 1833485.918op/s] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.811µs; 475.901µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2101279.061op/s; 2101676.088op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.914µs; 194.965µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5129132.584op/s; 5130483.918op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.855µs; 47.939µs] or [-0.088%; +0.088%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20860550.306op/s; 20897529.398op/s] or [-0.089%; +0.089%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.208µs; 50.242µs] or [-0.034%; +0.034%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19903866.912op/s; 19917294.235op/s] or [-0.034%; +0.034%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.294ms 6.307ms ± 0.007ms 6.306ms ± 0.004ms 6.310ms 6.315ms 6.321ms 6.375ms 1.10% 4.532 41.592 0.11% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.306ms; 6.308ms] or [-0.016%; +0.016%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.278µs 4.291µs ± 0.003µs 4.291µs ± 0.001µs 4.292µs 4.294µs 4.297µs 4.320µs 0.67% 4.073 37.916 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 231484515.861op/s 233026278.424op/s ± 169003.785op/s 233029403.742op/s ± 56541.179op/s 233090367.541op/s 233238609.049op/s 233322050.744op/s 233730886.409op/s 0.30% -4.023 37.439 0.07% 11950.372op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 92.588µs 93.507µs ± 0.516µs 93.465µs ± 0.243µs 93.710µs 94.222µs 94.436µs 98.292µs 5.16% 4.044 35.109 0.55% 0.037µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10173796.977op/s 10694733.662op/s ± 57834.186op/s 10699158.513op/s ± 27773.448op/s 10726776.449op/s 10767543.487op/s 10786156.001op/s 10800558.601op/s 0.95% -3.716 31.216 0.54% 4089.495op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 87.529µs 88.061µs ± 0.459µs 88.008µs ± 0.164µs 88.186µs 88.586µs 88.730µs 93.448µs 6.18% 8.192 93.141 0.52% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10701083.353op/s 11356099.931op/s ± 56836.352op/s 11362649.835op/s ± 21140.733op/s 11382295.709op/s 11405364.180op/s 11415975.449op/s 11424750.580op/s 0.55% -7.763 86.411 0.50% 4018.937op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.284µs 4.292µs ± 0.004µs 4.291µs ± 0.001µs 4.293µs 4.295µs 4.299µs 4.342µs 1.19% 7.946 90.793 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230292299.316op/s 233015176.214op/s ± 234384.356op/s 233031838.187op/s ± 77751.681op/s 233107034.005op/s 233223538.526op/s 233394441.328op/s 233428480.558op/s 0.17% -7.856 89.432 0.10% 16573.477op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 84.952µs 85.488µs ± 0.212µs 85.489µs ± 0.149µs 85.632µs 85.829µs 85.911µs 86.125µs 0.74% -0.002 -0.189 0.25% 0.015µs 1 200
credit_card/is_card_number/378282246310005 throughput 11611066.200op/s 11697554.324op/s ± 28992.965op/s 11697408.446op/s ± 20404.237op/s 11718128.531op/s 11743093.471op/s 11766940.055op/s 11771413.635op/s 0.63% 0.016 -0.190 0.25% 2050.112op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.973µs 59.068µs ± 0.031µs 59.065µs ± 0.018µs 59.086µs 59.117µs 59.142µs 59.184µs 0.20% 0.030 1.418 0.05% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16896493.769op/s 16929713.169op/s ± 8846.538op/s 16930471.632op/s ± 5094.772op/s 16934266.259op/s 16945243.987op/s 16952760.575op/s 16956910.794op/s 0.16% -0.024 1.415 0.05% 625.545op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.832µs 6.842µs ± 0.004µs 6.842µs ± 0.002µs 6.845µs 6.849µs 6.854µs 6.866µs 0.35% 0.950 3.877 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145638958.290op/s 146145880.485op/s ± 94369.279op/s 146149451.983op/s ± 53161.236op/s 146202328.480op/s 146294277.782op/s 146331173.352op/s 146367805.104op/s 0.15% -0.940 3.832 0.06% 6672.916op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.273µs 4.291µs ± 0.003µs 4.291µs ± 0.002µs 4.293µs 4.296µs 4.298µs 4.302µs 0.24% -0.874 7.706 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232464233.568op/s 233021082.521op/s ± 156382.007op/s 233023964.281op/s ± 89077.957op/s 233104178.405op/s 233218541.487op/s 233353866.144op/s 234009454.343op/s 0.42% 0.892 7.803 0.07% 11057.878op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 70.439µs 71.371µs ± 0.389µs 71.362µs ± 0.268µs 71.630µs 72.007µs 72.257µs 72.483µs 1.57% 0.008 -0.060 0.54% 0.027µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13796274.553op/s 14011745.680op/s ± 76296.481op/s 14013120.742op/s ± 52486.242op/s 14064001.189op/s 14152132.833op/s 14178808.574op/s 14196751.357op/s 1.31% 0.023 -0.069 0.54% 5394.976op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.463µs 66.206µs ± 0.337µs 66.216µs ± 0.241µs 66.428µs 66.781µs 66.924µs 67.194µs 1.48% 0.108 -0.320 0.51% 0.024µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14882369.163op/s 15104683.759op/s ± 76743.873op/s 15102201.146op/s ± 54933.850op/s 15158872.217op/s 15227358.463op/s 15266730.377op/s 15275897.376op/s 1.15% -0.083 -0.332 0.51% 5426.611op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.277µs 4.291µs ± 0.002µs 4.291µs ± 0.001µs 4.292µs 4.295µs 4.296µs 4.299µs 0.19% -0.638 4.868 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232608869.633op/s 233052390.855op/s ± 131625.036op/s 233056185.447op/s ± 68074.620op/s 233123854.399op/s 233267119.563op/s 233381842.188op/s 233791414.730op/s 0.32% 0.649 4.913 0.06% 9307.296op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 63.014µs 63.576µs ± 0.256µs 63.559µs ± 0.173µs 63.740µs 63.971µs 64.220µs 64.290µs 1.15% 0.325 -0.105 0.40% 0.018µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15554561.464op/s 15729552.524op/s ± 63245.315op/s 15733398.952op/s ± 42745.960op/s 15774015.873op/s 15829703.712op/s 15850618.384op/s 15869388.903op/s 0.86% -0.304 -0.128 0.40% 4472.119op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.983µs 59.071µs ± 0.030µs 59.067µs ± 0.017µs 59.085µs 59.130µs 59.148µs 59.182µs 0.19% 0.549 1.211 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16896925.376op/s 16928782.296op/s ± 8566.057op/s 16929816.599op/s ± 4751.116op/s 16933637.920op/s 16941627.706op/s 16947012.579op/s 16954007.169op/s 0.14% -0.545 1.206 0.05% 605.712op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.833µs 6.842µs ± 0.004µs 6.842µs ± 0.002µs 6.844µs 6.847µs 6.850µs 6.862µs 0.28% 0.573 3.911 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145738845.307op/s 146153333.077op/s ± 75748.616op/s 146152532.055op/s ± 46120.690op/s 146197631.013op/s 146270319.303op/s 146354135.814op/s 146359245.124op/s 0.14% -0.564 3.873 0.05% 5356.236op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.291µs; 4.292µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [233002856.125op/s; 233049700.723op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.435µs; 93.578µs] or [-0.077%; +0.077%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10686718.400op/s; 10702748.924op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [87.997µs; 88.124µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11348222.959op/s; 11363976.903op/s] or [-0.069%; +0.069%] None None None
credit_card/is_card_number/37828224631 execution_time [4.291µs; 4.292µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631 throughput [232982692.797op/s; 233047659.632op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.459µs; 85.518µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/378282246310005 throughput [11693536.178op/s; 11701572.470op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.063µs; 59.072µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16928487.124op/s; 16930939.214op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [146132801.811op/s; 146158959.160op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.291µs; 4.292µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [232999409.479op/s; 233042755.563op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [71.317µs; 71.425µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14001171.722op/s; 14022319.639op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.160µs; 66.253µs] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15094047.797op/s; 15115319.722op/s] or [-0.070%; +0.070%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.291µs; 4.291µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233034148.891op/s; 233070632.819op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.540µs; 63.611µs] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15720787.332op/s; 15738317.717op/s] or [-0.056%; +0.056%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.067µs; 59.075µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16927595.123op/s; 16929969.469op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146142835.047op/s; 146163831.107op/s] or [-0.007%; +0.007%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.508µs 76.777µs ± 0.221µs 76.747µs ± 0.078µs 76.850µs 76.937µs 77.004µs 79.482µs 3.56% 9.188 110.360 0.29% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.746µs; 76.807µs] or [-0.040%; +0.040%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 298.157µs 302.131µs ± 1.111µs 302.205µs ± 0.621µs 302.766µs 303.797µs 304.468µs 304.613µs 0.80% -0.446 0.740 0.37% 0.079µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3282857.973op/s 3309872.259op/s ± 12187.872op/s 3309012.704op/s ± 6794.532op/s 3316237.311op/s 3331693.022op/s 3339980.133op/s 3353932.274op/s 1.36% 0.475 0.786 0.37% 861.813op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.076µs 27.290µs ± 0.131µs 27.284µs ± 0.064µs 27.337µs 27.444µs 27.665µs 28.485µs 4.40% 4.105 33.568 0.48% 0.009µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35106278.407op/s 36644869.258op/s ± 173035.322op/s 36651242.376op/s ± 85343.433op/s 36743767.344op/s 36850968.305op/s 36914622.493op/s 36933207.174op/s 0.77% -3.845 30.530 0.47% 12235.445op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.855µs 15.991µs ± 0.061µs 15.983µs ± 0.038µs 16.024µs 16.111µs 16.157µs 16.183µs 1.25% 0.673 0.527 0.38% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 61791816.041op/s 62537240.627op/s ± 239561.980op/s 62567107.348op/s ± 149294.160op/s 62708560.908op/s 62893073.413op/s 62983757.649op/s 63070237.796op/s 0.80% -0.649 0.489 0.38% 16939.590op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [301.977µs; 302.284µs] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3308183.138op/s; 3311561.381op/s] or [-0.051%; +0.051%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.271µs; 27.308µs] or [-0.067%; +0.067%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36620888.227op/s; 36668850.290op/s] or [-0.065%; +0.065%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.982µs; 15.999µs] or [-0.053%; +0.053%] None None None
normalization/normalize_name/normalize_name/good throughput [62504039.641op/s; 62570441.614op/s] or [-0.053%; +0.053%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 61.074ms 61.295ms ± 0.129ms 61.265ms ± 0.049ms 61.340ms 61.483ms 61.812ms 62.080ms 1.33% 2.565 10.377 0.21% 0.009ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.277ms; 61.313ms] or [-0.029%; +0.029%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.799µs 2.826µs ± 0.024µs 2.818µs ± 0.008µs 2.830µs 2.895µs 2.901µs 2.902µs 2.98% 2.013 3.384 0.85% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.822µs; 2.829µs] or [-0.119%; +0.119%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.593µs 37.003µs ± 0.728µs 36.667µs ± 0.033µs 36.736µs 38.465µs 38.519µs 40.175µs 9.57% 1.868 2.244 1.96% 0.051µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [36.902µs; 37.104µs] or [-0.273%; +0.273%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.393µs 3.363µs ± 1.508µs 3.143µs ± 0.031µs 3.170µs 3.843µs 14.579µs 15.574µs 395.55% 7.371 55.359 44.73% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.154µs; 3.572µs] or [-6.215%; +6.215%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.553µs 27.924µs ± 13.808µs 18.791µs ± 0.151µs 36.221µs 45.692µs 48.128µs 145.460µs 674.08% 3.939 27.827 49.32% 0.976µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.010µs; 29.837µs] or [-6.853%; +6.853%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.869µs 138.646µs ± 0.321µs 138.592µs ± 0.131µs 138.747µs 139.161µs 139.982µs 140.839µs 1.62% 2.777 14.240 0.23% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.601µs; 138.690µs] or [-0.032%; +0.032%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz dbc8869 1734723835 jordan.gonzalez/hardcode-metric-filtering
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.395ns 307.492ns ± 11.685ns 304.272ns ± 5.773ns 311.507ns 335.965ns 347.051ns 347.365ns 14.16% 1.833 3.105 3.79% 0.826ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.872ns; 309.111ns] or [-0.527%; +0.527%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.01%. Comparing base (9d898c9) to head (dbc8869).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #761   +/-   ##
=======================================
  Coverage   71.00%   71.01%           
=======================================
  Files         313      313           
  Lines       45898    45903    +5     
=======================================
+ Hits        32592    32597    +5     
  Misses      13306    13306           
Components Coverage Δ
crashtracker 38.27% <ø> (ø)
crashtracker-ffi 5.71% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.87% <ø> (ø)
data-pipeline-ffi 90.54% <ø> (ø)
ddcommon 82.03% <ø> (ø)
ddcommon-ffi 65.60% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.64% <100.00%> (+0.04%) ⬆️
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.91% <ø> (ø)
sidecar-ffi 3.98% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.79% <ø> (ø)

@github-actions github-actions bot removed the common label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants