-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: split networking from ddcommon into ddcommon-net1 #765
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
- Coverage 70.55% 70.50% -0.05%
==========================================
Files 297 297
Lines 43545 43557 +12
==========================================
- Hits 30723 30710 -13
- Misses 12822 12847 +25
|
BenchmarksComparisonBenchmark execution time: 2025-01-16 22:00:19 Comparing candidate commit b713817 in PR branch Found 0 performance improvements and 11 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
BaselineOmitted due to size. |
The name "net1" is here because I intend to make net2 shortly in a stacked PR. The splitting out of this networking code from the core common code is to allow this to happen.
c665eb4
to
b713817
Compare
What does this PR do?
This PR splits out a variety of networking types and functions from
ddcommon
intoddcommon-net1
. It does this so that a dependency onddcommon
does not havehyper
or other hyper-related crates as a dependency. This allows introducingddcommon-net2
which can also depend on things inddcommon
such asentity_id
.Motivation
During the initial "hyper 0.14 to hyper 1.x" migration PR, some code between
ddcommon
and the new hyper was duplicated, and that was okay. But on Windows, the dependency onddcommon
was causing linking issues because in that version,ddcommon
still had a version of hyper. Or at least, that's the thesis. I made this draft PR to test it.Additional Notes
The name "net1" is here because I intend to make net2 shortly in a stacked PR. The splitting out of this networking code from the core common code is to allow this to happen.
How to test the change?
This ought to be a pure refactoring. No changes should need to be made.