Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split networking from ddcommon into ddcommon-net1 #765

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morrisonlevi
Copy link
Contributor

What does this PR do?

This PR splits out a variety of networking types and functions from ddcommon into ddcommon-net1. It does this so that a dependency on ddcommon does not have hyper or other hyper-related crates as a dependency. This allows introducing ddcommon-net2 which can also depend on things in ddcommon such as entity_id.

Motivation

During the initial "hyper 0.14 to hyper 1.x" migration PR, some code between ddcommon and the new hyper was duplicated, and that was okay. But on Windows, the dependency on ddcommon was causing linking issues because in that version, ddcommon still had a version of hyper. Or at least, that's the thesis. I made this draft PR to test it.

Additional Notes

The name "net1" is here because I intend to make net2 shortly in a stacked PR. The splitting out of this networking code from the core common code is to allow this to happen.

How to test the change?

This ought to be a pure refactoring. No changes should need to be made.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 65.78947% with 52 lines in your changes missing coverage. Please review.

Project coverage is 70.50%. Comparing base (a3c1bd4) to head (c665eb4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   70.55%   70.50%   -0.05%     
==========================================
  Files         297      297              
  Lines       43545    43557      +12     
==========================================
- Hits        30723    30710      -13     
- Misses      12822    12847      +25     
Components Coverage Δ
crashtracker 44.89% <40.00%> (ø)
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.48% <50.00%> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.27% <65.94%> (-0.19%) ⬇️
ddcommon-ffi 68.50% <35.29%> (-0.63%) ⬇️
ddtelemetry 59.07% <66.66%> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (-0.11%) ⬇️
profiling 84.30% <100.00%> (+<0.01%) ⬆️
profiling-ffi 77.50% <100.00%> (+0.03%) ⬆️
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 93.47% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.29% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Dec 2, 2024

Benchmarks

Comparison

Benchmark execution time: 2025-01-16 22:00:19

Comparing candidate commit b713817 in PR branch levi/split-net with baseline commit 6e2d446 in branch main.

Found 0 performance improvements and 11 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+9.216µs; +9.365µs] or [+10.298%; +10.464%]
  • 🟥 throughput [-1059275.640op/s; -1042412.943op/s] or [-9.480%; -9.330%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+9.521µs; +9.654µs] or [+11.773%; +11.937%]
  • 🟥 throughput [-1319109.364op/s; -1301852.463op/s] or [-10.668%; -10.528%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+10.903µs; +10.955µs] or [+14.077%; +14.144%]
  • 🟥 throughput [-1600873.653op/s; -1592470.611op/s] or [-12.399%; -12.334%]

scenario:credit_card/is_card_number/x371413321323331

  • 🟥 execution_time [+1.594µs; +1.596µs] or [+24.709%; +24.747%]
  • 🟥 throughput [-30763599.465op/s; -30708021.330op/s] or [-19.843%; -19.808%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟥 execution_time [+1.594µs; +1.597µs] or [+24.711%; +24.750%]
  • 🟥 throughput [-30766312.058op/s; -30709317.296op/s] or [-19.846%; -19.809%]

scenario:sql/obfuscate_sql_string

  • 🟥 execution_time [+7.751µs; +8.081µs] or [+11.328%; +11.811%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.273µs 30.226µs ± 18.723µs 19.670µs ± 0.196µs 38.614µs 48.106µs 108.310µs 195.848µs 895.66% 5.047 36.985 61.79% 1.324µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [27.631µs; 32.820µs] or [-8.585%; +8.585%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.620µs 2.687µs ± 0.020µs 2.687µs ± 0.007µs 2.695µs 2.721µs 2.735µs 2.739µs 1.92% -0.753 2.686 0.73% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.685µs; 2.690µs] or [-0.102%; +0.102%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 139.945µs 141.049µs ± 0.383µs 140.988µs ± 0.177µs 141.169µs 141.863µs 142.255µs 143.054µs 1.47% 1.630 4.902 0.27% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [140.996µs; 141.102µs] or [-0.038%; +0.038%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.485ms 6.499ms ± 0.013ms 6.497ms ± 0.004ms 6.501ms 6.510ms 6.570ms 6.581ms 1.30% 4.092 20.059 0.20% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.498ms; 6.501ms] or [-0.028%; +0.028%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 59.270ms 60.066ms ± 0.213ms 60.053ms ± 0.081ms 60.144ms 60.419ms 60.732ms 60.857ms 1.34% 0.368 3.231 0.35% 0.015ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.037ms; 60.096ms] or [-0.049%; +0.049%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.465µs 5.505µs ± 0.034µs 5.489µs ± 0.014µs 5.530µs 5.571µs 5.574µs 5.650µs 2.93% 1.156 0.697 0.62% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.501µs; 5.510µs] or [-0.086%; +0.086%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.836µs 38.331µs ± 0.762µs 37.997µs ± 0.068µs 38.122µs 39.847µs 39.899µs 42.806µs 12.66% 2.222 5.571 1.98% 0.054µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.225µs; 38.436µs] or [-0.276%; +0.276%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 296.824µs 300.091µs ± 1.173µs 300.224µs ± 0.790µs 300.865µs 301.939µs 302.859µs 303.058µs 0.94% -0.158 -0.147 0.39% 0.083µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3299702.843op/s 3332377.366op/s ± 13029.048op/s 3330848.774op/s ± 8737.201op/s 3341198.660op/s 3353973.208op/s 3363511.802op/s 3368998.130op/s 1.15% 0.180 -0.142 0.39% 921.293op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.074µs 27.346µs ± 0.094µs 27.344µs ± 0.050µs 27.398µs 27.473µs 27.515µs 28.023µs 2.48% 1.624 12.074 0.34% 0.007µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35685264.127op/s 36569330.117op/s ± 125576.829op/s 36571183.371op/s ± 67058.998op/s 36635778.352op/s 36763893.654op/s 36826171.375op/s 36935961.485op/s 1.00% -1.509 11.171 0.34% 8879.623op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.793µs 15.915µs ± 0.057µs 15.914µs ± 0.042µs 15.956µs 16.006µs 16.023µs 16.086µs 1.08% 0.051 -0.552 0.35% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 62166906.554op/s 62835080.365op/s ± 223407.601op/s 62836213.687op/s ± 166496.905op/s 63002854.915op/s 63212181.695op/s 63280608.563op/s 63319327.957op/s 0.77% -0.036 -0.561 0.35% 15797.303op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [299.928µs; 300.253µs] or [-0.054%; +0.054%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3330571.665op/s; 3334183.067op/s] or [-0.054%; +0.054%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.333µs; 27.359µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36551926.376op/s; 36586733.857op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.907µs; 15.923µs] or [-0.049%; +0.049%] None None None
normalization/normalize_name/normalize_name/good throughput [62804118.220op/s; 62866042.510op/s] or [-0.049%; +0.049%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.410µs 3.271µs ± 1.464µs 3.110µs ± 0.019µs 3.126µs 3.187µs 14.391µs 15.370µs 394.27% 7.622 58.004 44.65% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.068µs; 3.473µs] or [-6.203%; +6.203%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 543.684µs 544.911µs ± 0.965µs 544.737µs ± 0.330µs 545.084µs 546.153µs 548.553µs 553.596µs 1.63% 4.940 35.984 0.18% 0.068µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1806370.210op/s 1835168.211op/s ± 3221.969op/s 1835749.208op/s ± 1112.576op/s 1836809.256op/s 1837727.755op/s 1838537.747op/s 1839304.982op/s 0.19% -4.869 35.094 0.18% 227.828op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 475.181µs 475.943µs ± 0.323µs 475.920µs ± 0.180µs 476.117µs 476.428µs 476.577µs 478.077µs 0.45% 1.422 8.736 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2091711.187op/s 2101094.535op/s ± 1425.014op/s 2101192.897op/s ± 794.358op/s 2101808.391op/s 2103380.056op/s 2104010.219op/s 2104461.014op/s 0.16% -1.405 8.612 0.07% 100.764op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.418µs 194.920µs ± 0.199µs 194.958µs ± 0.117µs 195.062µs 195.177µs 195.265µs 195.448µs 0.25% -0.570 -0.068 0.10% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5116451.100op/s 5130302.824op/s ± 5244.130op/s 5129315.442op/s ± 3073.138op/s 5133457.570op/s 5140780.025op/s 5142882.297op/s 5143565.717op/s 0.28% 0.575 -0.065 0.10% 370.816op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.007µs 47.577µs ± 0.231µs 47.566µs ± 0.127µs 47.699µs 47.876µs 47.950µs 49.451µs 3.96% 2.512 20.053 0.48% 0.016µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20221889.815op/s 21019111.626op/s ± 101008.966op/s 21023472.936op/s ± 56384.748op/s 21074192.913op/s 21184171.716op/s 21198727.833op/s 21273266.672op/s 1.19% -2.292 17.937 0.48% 7142.412op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 50.080µs 50.364µs ± 0.178µs 50.357µs ± 0.073µs 50.419µs 50.535µs 50.821µs 52.024µs 3.31% 5.100 42.132 0.35% 0.013µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19221997.564op/s 19855839.155op/s ± 68819.851op/s 19858395.663op/s ± 28745.978op/s 19888233.982op/s 19931911.887op/s 19954660.008op/s 19967994.828op/s 0.55% -4.912 39.921 0.35% 4866.298op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [544.777µs; 545.045µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1834721.678op/s; 1835614.745op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.898µs; 475.987µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2100897.041op/s; 2101292.028op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.893µs; 194.948µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5129576.038op/s; 5131029.610op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.545µs; 47.609µs] or [-0.067%; +0.067%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21005112.755op/s; 21033110.497op/s] or [-0.067%; +0.067%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.339µs; 50.388µs] or [-0.049%; +0.049%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19846301.385op/s; 19865376.924op/s] or [-0.048%; +0.048%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.424µs 4.432µs ± 0.003µs 4.432µs ± 0.001µs 4.433µs 4.435µs 4.438µs 4.452µs 0.44% 2.009 15.398 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 224642786.120op/s 225630403.622op/s ± 132663.039op/s 225633742.719op/s ± 59917.436op/s 225696670.977op/s 225849944.068op/s 225899742.023op/s 226053185.497op/s 0.19% -1.985 15.215 0.06% 9380.693op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 98.468µs 98.792µs ± 0.372µs 98.778µs ± 0.062µs 98.835µs 98.926µs 99.059µs 103.826µs 5.11% 12.514 167.184 0.38% 0.026µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 9631536.142op/s 10122424.788op/s ± 36370.869op/s 10123672.571op/s ± 6393.493op/s 10130948.973op/s 10142876.840op/s 10147247.515op/s 10155545.117op/s 0.31% -12.370 164.613 0.36% 2571.809op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 90.267µs 90.459µs ± 0.391µs 90.416µs ± 0.037µs 90.468µs 90.526µs 91.163µs 95.802µs 5.96% 12.904 173.127 0.43% 0.028µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10438225.874op/s 11054945.614op/s ± 45280.045op/s 11059994.892op/s ± 4538.123op/s 11063036.735op/s 11069566.165op/s 11078087.488op/s 11078281.030op/s 0.17% -12.791 170.933 0.41% 3201.783op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.421µs 4.431µs ± 0.008µs 4.431µs ± 0.001µs 4.432µs 4.435µs 4.481µs 4.504µs 1.64% 6.813 52.048 0.19% 0.001µs 1 200
credit_card/is_card_number/37828224631 throughput 222049211.337op/s 225664015.347op/s ± 416785.758op/s 225682588.633op/s ± 70590.366op/s 225783472.654op/s 226006187.705op/s 226071566.429op/s 226209597.719op/s 0.23% -6.770 51.574 0.18% 29471.204op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 88.214µs 88.379µs ± 0.076µs 88.376µs ± 0.023µs 88.397µs 88.453µs 88.577µs 88.963µs 0.66% 4.125 29.974 0.09% 0.005µs 1 200
credit_card/is_card_number/378282246310005 throughput 11240573.817op/s 11314949.481op/s ± 9727.974op/s 11315231.940op/s ± 2950.054op/s 11318349.146op/s 11327880.484op/s 11332876.848op/s 11336063.468op/s 0.18% -4.087 29.629 0.09% 687.872op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 60.175µs 60.264µs ± 0.032µs 60.261µs ± 0.014µs 60.279µs 60.319µs 60.358µs 60.388µs 0.21% 0.440 2.346 0.05% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16559660.667op/s 16593669.986op/s ± 8703.335op/s 16594421.785op/s ± 3901.784op/s 16597885.844op/s 16608666.157op/s 16614912.519op/s 16618270.126op/s 0.14% -0.433 2.337 0.05% 615.419op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 8.034µs 8.045µs ± 0.004µs 8.045µs ± 0.002µs 8.047µs 8.051µs 8.054µs 8.062µs 0.21% 0.109 1.528 0.05% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 124036115.249op/s 124296314.244op/s ± 62081.193op/s 124293567.418op/s ± 30059.307op/s 124327572.976op/s 124404336.174op/s 124438423.264op/s 124469179.970op/s 0.14% -0.103 1.518 0.05% 4389.803op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.419µs 4.431µs ± 0.003µs 4.431µs ± 0.002µs 4.433µs 4.435µs 4.437µs 4.438µs 0.16% -0.781 1.867 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 225304230.589op/s 225678484.889op/s ± 138898.680op/s 225666838.259op/s ± 77358.610op/s 225738573.081op/s 225918134.139op/s 226044901.918op/s 226311448.271op/s 0.29% 0.787 1.886 0.06% 9821.620op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 70.612µs 70.811µs ± 0.095µs 70.792µs ± 0.060µs 70.875µs 70.987µs 71.053µs 71.120µs 0.46% 0.639 0.103 0.13% 0.007µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14060816.199op/s 14122049.355op/s ± 18985.030op/s 14125973.542op/s ± 12015.823op/s 14136191.705op/s 14146752.052op/s 14155469.497op/s 14161965.210op/s 0.25% -0.632 0.092 0.13% 1342.444op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 63.047µs 63.273µs ± 0.080µs 63.275µs ± 0.033µs 63.300µs 63.366µs 63.467µs 63.850µs 0.91% 2.834 19.189 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15661627.951op/s 15804503.543op/s ± 19909.776op/s 15804143.057op/s ± 8319.858op/s 15813828.007op/s 15832051.280op/s 15839886.233op/s 15861112.868op/s 0.36% -2.785 18.805 0.13% 1407.834op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.415µs 4.430µs ± 0.003µs 4.431µs ± 0.001µs 4.432µs 4.434µs 4.435µs 4.435µs 0.10% -1.458 2.715 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 225461109.406op/s 225734090.257op/s ± 177967.681op/s 225684686.410op/s ± 75461.564op/s 225809455.777op/s 226053500.192op/s 226336818.835op/s 226483390.984op/s 0.35% 1.464 2.740 0.08% 12584.215op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 60.681µs 60.884µs ± 0.096µs 60.878µs ± 0.051µs 60.933µs 60.985µs 61.157µs 61.716µs 1.38% 3.315 26.872 0.16% 0.007µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16203236.110op/s 16424730.566op/s ± 25861.458op/s 16426199.550op/s ± 13736.364op/s 16436700.214op/s 16460878.336op/s 16472085.614op/s 16479512.670op/s 0.32% -3.232 25.986 0.16% 1828.681op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 60.173µs 60.276µs ± 0.038µs 60.271µs ± 0.019µs 60.294µs 60.356µs 60.378µs 60.395µs 0.21% 0.571 0.828 0.06% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16557643.891op/s 16590417.950op/s ± 10431.025op/s 16591612.111op/s ± 5165.689op/s 16596414.760op/s 16606296.693op/s 16613668.418op/s 16618829.133op/s 0.16% -0.567 0.825 0.06% 737.585op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 8.030µs 8.046µs ± 0.005µs 8.046µs ± 0.002µs 8.048µs 8.053µs 8.058µs 8.061µs 0.19% 0.022 1.207 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 124051970.490op/s 124290546.398op/s ± 71899.314op/s 124288695.943op/s ± 37893.049op/s 124327731.314op/s 124407800.626op/s 124460039.314op/s 124531928.263op/s 0.20% -0.017 1.205 0.06% 5084.049op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.432µs; 4.432µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [225612017.800op/s; 225648789.443op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [98.740µs; 98.843µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10117384.135op/s; 10127465.440op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [90.405µs; 90.513µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11048670.235op/s; 11061220.993op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [4.430µs; 4.433µs] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/37828224631 throughput [225606252.849op/s; 225721777.845op/s] or [-0.026%; +0.026%] None None None
credit_card/is_card_number/378282246310005 execution_time [88.368µs; 88.389µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/378282246310005 throughput [11313601.277op/s; 11316297.684op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [60.260µs; 60.268µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16592463.787op/s; 16594876.185op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 execution_time [8.045µs; 8.046µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/x371413321323331 throughput [124287710.388op/s; 124304918.100op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.431µs; 4.431µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ throughput [225659234.868op/s; 225697734.910op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [70.798µs; 70.825µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14119418.213op/s; 14124680.498op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [63.262µs; 63.284µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15801744.240op/s; 15807262.847op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.430µs; 4.430µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [225709425.648op/s; 225758754.866op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [60.871µs; 60.897µs] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16421146.416op/s; 16428314.715op/s] or [-0.022%; +0.022%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [60.271µs; 60.281µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16588972.311op/s; 16591863.590op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [8.045µs; 8.046µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [124280581.845op/s; 124300510.951op/s] or [-0.008%; +0.008%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.084µs 76.338µs ± 0.152µs 76.321µs ± 0.059µs 76.385µs 76.504µs 76.632µs 77.999µs 2.20% 6.695 69.711 0.20% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.317µs; 76.359µs] or [-0.028%; +0.028%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz b713817 1737064143 levi/split-net
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 305.330ns 313.673ns ± 10.714ns 309.358ns ± 2.317ns 313.712ns 339.936ns 349.781ns 351.468ns 13.61% 2.162 3.695 3.41% 0.758ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [312.188ns; 315.158ns] or [-0.473%; +0.473%] None None None

Baseline

Omitted due to size.

The name "net1" is here because I intend to make net2 shortly in a
stacked PR. The splitting out of this networking code from the core
common code is to allow this to happen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants