Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: ddcommon-net2 crate #766

Draft
wants to merge 14 commits into
base: levi/split-net
Choose a base branch
from
Draft

feature: ddcommon-net2 crate #766

wants to merge 14 commits into from

Conversation

morrisonlevi
Copy link
Contributor

What does this PR do?

This adds the ddcommon-net2 crate which uses hyper 1, unlike ddcommon-net1 which uses hyper 0.14. The datadog-profiling and datadog-profiling-ffi crates are moved to use ddcommon-net2.

Motivation

Hyper migration.

Additional Notes

I was hoping that this specific implementation strategy would get rid of a specific linking issue I hit on Windows in another PR. However, ddcommon-ffi depends on ddcommon-net1 so both net crates are in play. The relationships are a bit different (better, IMO) but it didn't outright fix the issue. I think all crates built together on Windows need to have the same hyper version dependency :'(

How to test the change?

Describe here in detail how the change can be validated.

@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Nov 27, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 2, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-12-04 23:00:05

Comparing candidate commit 3c7a240 in PR branch levi/ddcommon-net2 with baseline commit c665eb4 in branch levi/split-net.

Found 1 performance improvements and 6 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

scenario:credit_card/is_card_number/x371413321323331

  • 🟥 execution_time [+680.673ns; +682.371ns] or [+10.369%; +10.395%]
  • 🟥 throughput [-14345726.426op/s; -14310674.429op/s] or [-9.417%; -9.394%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+5.057µs; +5.113µs] or [+7.293%; +7.373%]
  • 🟥 throughput [-990768.458op/s; -979712.912op/s] or [-6.870%; -6.794%]

scenario:credit_card/is_card_number_no_luhn/x371413321323331

  • 🟥 execution_time [+679.911ns; +681.815ns] or [+10.356%; +10.385%]
  • 🟥 throughput [-14331789.469op/s; -14292207.359op/s] or [-9.409%; -9.383%]

scenario:redis/obfuscate_redis_string

  • 🟩 execution_time [-2.223µs; -1.912µs] or [-5.622%; -4.833%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.458µs 24.369µs ± 14.215µs 18.683µs ± 0.092µs 19.143µs 46.907µs 49.549µs 163.518µs 775.22% 5.610 46.699 58.19% 1.005µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.399µs; 26.339µs] or [-8.084%; +8.084%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.385µs 3.234µs ± 1.441µs 3.075µs ± 0.020µs 3.091µs 3.155µs 14.238µs 15.220µs 394.98% 7.604 57.823 44.46% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.034µs; 3.434µs] or [-6.177%; +6.177%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.098µs 37.481µs ± 0.641µs 37.194µs ± 0.048µs 37.287µs 38.760µs 38.822µs 41.227µs 10.84% 2.206 5.469 1.71% 0.045µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.392µs; 37.570µs] or [-0.237%; +0.237%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.231µs 143.043µs ± 0.377µs 143.013µs ± 0.148µs 143.171µs 143.535µs 144.048µs 146.174µs 2.21% 3.219 23.345 0.26% 0.027µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.991µs; 143.095µs] or [-0.037%; +0.037%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 70.037µs 70.231µs ± 0.173µs 70.198µs ± 0.053µs 70.277µs 70.405µs 70.739µs 72.032µs 2.61% 6.619 60.851 0.25% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [70.207µs; 70.255µs] or [-0.034%; +0.034%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.990ms 59.537ms ± 0.295ms 59.549ms ± 0.252ms 59.792ms 59.889ms 60.065ms 60.433ms 1.48% 0.029 -0.889 0.49% 0.021ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [59.496ms; 59.578ms] or [-0.069%; +0.069%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.684µs 2.735µs ± 0.018µs 2.733µs ± 0.004µs 2.738µs 2.780µs 2.790µs 2.804µs 2.60% 0.971 3.746 0.66% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.732µs; 2.737µs] or [-0.091%; +0.091%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.181ms 9.211ms ± 0.015ms 9.211ms ± 0.009ms 9.219ms 9.237ms 9.253ms 9.282ms 0.77% 0.783 2.174 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.209ms; 9.213ms] or [-0.023%; +0.023%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 508.378µs 509.421µs ± 0.690µs 509.334µs ± 0.217µs 509.605µs 509.945µs 510.341µs 517.961µs 1.69% 9.513 115.467 0.14% 0.049µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1930647.069op/s 1963016.093op/s ± 2626.560op/s 1963349.576op/s ± 835.103op/s 1964043.845op/s 1964997.091op/s 1966502.800op/s 1967041.411op/s 0.19% -9.404 113.686 0.13% 185.726op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 465.609µs 466.394µs ± 0.445µs 466.304µs ± 0.266µs 466.614µs 467.141µs 467.466µs 468.780µs 0.53% 1.389 3.851 0.10% 0.031µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2133195.132op/s 2144111.783op/s ± 2041.544op/s 2144523.381op/s ± 1221.884op/s 2145504.927op/s 2146567.444op/s 2147153.114op/s 2147724.565op/s 0.15% -1.377 3.786 0.09% 144.359op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 175.793µs 176.701µs ± 0.567µs 176.667µs ± 0.237µs 176.887µs 177.215µs 177.451µs 183.082µs 3.63% 7.135 78.136 0.32% 0.040µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5462046.504op/s 5659320.689op/s ± 17772.276op/s 5660372.930op/s ± 7589.992op/s 5668421.274op/s 5675989.586op/s 5682305.334op/s 5688507.065op/s 0.50% -6.858 74.065 0.31% 1256.690op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.237µs 45.484µs ± 0.104µs 45.487µs ± 0.064µs 45.547µs 45.659µs 45.733µs 45.769µs 0.62% 0.102 -0.130 0.23% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21848700.692op/s 21985902.461op/s ± 50162.593op/s 21984267.232op/s ± 30926.883op/s 22017014.848op/s 22065546.468op/s 22094458.205op/s 22105985.501op/s 0.55% -0.090 -0.137 0.23% 3547.031op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 41.933µs 42.151µs ± 0.095µs 42.137µs ± 0.055µs 42.202µs 42.322µs 42.465µs 42.509µs 0.88% 1.051 1.934 0.23% 0.007µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 23524164.953op/s 23724078.415op/s ± 53535.381op/s 23732226.361op/s ± 30740.058op/s 23760264.868op/s 23793166.009op/s 23818671.132op/s 23847359.017op/s 0.49% -1.032 1.878 0.23% 3785.523op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [509.325µs; 509.517µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1962652.077op/s; 1963380.109op/s] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [466.332µs; 466.456µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2143828.845op/s; 2144394.722op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [176.623µs; 176.780µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5656857.623op/s; 5661783.756op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [45.470µs; 45.498µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21978950.408op/s; 21992854.514op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [42.138µs; 42.165µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [23716658.926op/s; 23731497.904op/s] or [-0.031%; +0.031%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.162µs 280.717µs ± 0.273µs 280.698µs ± 0.185µs 280.883µs 281.165µs 281.444µs 282.064µs 0.49% 0.927 2.661 0.10% 0.019µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3545299.452op/s 3562311.765op/s ± 3464.201op/s 3562551.807op/s ± 2354.128op/s 3564900.238op/s 3567140.317op/s 3569021.811op/s 3569366.515op/s 0.19% -0.916 2.612 0.10% 244.956op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.211µs 27.317µs ± 0.046µs 27.312µs ± 0.031µs 27.346µs 27.392µs 27.451µs 27.510µs 0.73% 0.776 1.184 0.17% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36350216.682op/s 36607952.774op/s ± 61938.599op/s 36614102.194op/s ± 41919.099op/s 36652099.496op/s 36689607.811op/s 36724233.379op/s 36749535.118op/s 0.37% -0.763 1.145 0.17% 4379.720op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.551µs 16.909µs ± 0.154µs 16.987µs ± 0.030µs 17.009µs 17.041µs 17.064µs 17.075µs 0.52% -1.074 -0.606 0.91% 0.011µs 1 200
normalization/normalize_name/normalize_name/good throughput 58565476.202op/s 59144421.980op/s ± 545331.430op/s 58870190.515op/s ± 103628.882op/s 59736190.230op/s 60143326.187op/s 60366525.016op/s 60420994.901op/s 2.63% 1.081 -0.592 0.92% 38560.755op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [280.679µs; 280.755µs] or [-0.013%; +0.013%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3561831.660op/s; 3562791.870op/s] or [-0.013%; +0.013%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.310µs; 27.323µs] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36599368.680op/s; 36616536.868op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.888µs; 16.931µs] or [-0.127%; +0.127%] None None None
normalization/normalize_name/normalize_name/good throughput [59068844.289op/s; 59219999.672op/s] or [-0.128%; +0.128%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.617µs 4.631µs ± 0.006µs 4.631µs ± 0.003µs 4.634µs 4.639µs 4.642µs 4.688µs 1.23% 4.390 40.202 0.13% 0.000µs 1 200
credit_card/is_card_number/ throughput 213310390.616op/s 215922523.394op/s ± 274732.204op/s 215944621.011op/s ± 134748.086op/s 216077155.763op/s 216226680.175op/s 216378903.478op/s 216570750.556op/s 0.29% -4.303 39.133 0.13% 19426.500op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.314µs 92.806µs ± 0.550µs 92.831µs ± 0.222µs 93.055µs 93.405µs 93.835µs 97.381µs 4.90% 2.117 24.605 0.59% 0.039µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10268918.247op/s 10775529.773op/s ± 63116.148op/s 10772314.076op/s ± 25809.544op/s 10797864.729op/s 10870971.411op/s 10922852.064op/s 11072438.455op/s 2.79% -1.740 21.779 0.58% 4462.986op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.947µs 84.948µs ± 0.418µs 84.995µs ± 0.081µs 85.064µs 85.196µs 85.322µs 89.608µs 5.43% 6.579 76.148 0.49% 0.030µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11159699.940op/s 11772240.948op/s ± 56137.081op/s 11765399.139op/s ± 11263.768op/s 11781384.536op/s 11847816.798op/s 11897453.246op/s 11912288.808op/s 1.25% -6.075 69.560 0.48% 3969.491op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.620µs 4.632µs ± 0.005µs 4.632µs ± 0.003µs 4.634µs 4.639µs 4.645µs 4.682µs 1.10% 4.150 36.445 0.12% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 213570802.973op/s 215896085.811op/s ± 250748.697op/s 215911648.970op/s ± 118929.544op/s 216034182.009op/s 216203080.637op/s 216324267.915op/s 216462233.453op/s 0.26% -4.076 35.569 0.12% 17730.610op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 80.456µs 81.052µs ± 0.282µs 80.965µs ± 0.113µs 81.212µs 81.632µs 82.104µs 82.174µs 1.49% 1.519 3.009 0.35% 0.020µs 1 200
credit_card/is_card_number/378282246310005 throughput 12169325.566op/s 12337937.209op/s ± 42734.155op/s 12351059.545op/s ± 17249.754op/s 12364460.524op/s 12385202.717op/s 12405133.986op/s 12429156.315op/s 0.63% -1.491 2.901 0.35% 3021.761op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.384µs 59.482µs ± 0.037µs 59.478µs ± 0.017µs 59.496µs 59.532µs 59.600µs 59.758µs 0.47% 2.563 15.778 0.06% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16734250.595op/s 16811744.595op/s ± 10415.775op/s 16812991.090op/s ± 4899.416op/s 16817572.453op/s 16823310.184op/s 16835161.363op/s 16839542.674op/s 0.16% -2.542 15.601 0.06% 736.507op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 7.235µs 7.246µs ± 0.005µs 7.246µs ± 0.003µs 7.248µs 7.254µs 7.259µs 7.260µs 0.19% 0.227 0.298 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 137746185.149op/s 138008848.799op/s ± 93329.078op/s 138010713.969op/s ± 50465.433op/s 138062516.028op/s 138168662.917op/s 138213271.304op/s 138219767.428op/s 0.15% -0.222 0.294 0.07% 6599.362op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.615µs 4.632µs ± 0.005µs 4.632µs ± 0.003µs 4.635µs 4.642µs 4.644µs 4.649µs 0.35% 0.203 0.618 0.11% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215122975.811op/s 215878983.310op/s ± 232901.933op/s 215884316.027op/s ± 143220.131op/s 216035946.055op/s 216229982.167op/s 216332301.821op/s 216693466.466op/s 0.37% -0.195 0.619 0.11% 16468.654op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 74.059µs 74.430µs ± 0.124µs 74.437µs ± 0.080µs 74.502µs 74.615µs 74.752µs 74.928µs 0.66% 0.222 1.161 0.17% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13346077.024op/s 13435512.691op/s ± 22456.740op/s 13434125.111op/s ± 14385.174op/s 13449667.310op/s 13469614.707op/s 13488803.829op/s 13502759.964op/s 0.51% -0.207 1.136 0.17% 1587.931op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.844µs 66.032µs ± 0.086µs 66.031µs ± 0.061µs 66.090µs 66.173µs 66.240µs 66.251µs 0.33% 0.134 -0.306 0.13% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15094033.845op/s 15144211.634op/s ± 19647.024op/s 15144332.464op/s ± 13916.500op/s 15158336.933op/s 15176829.914op/s 15183145.460op/s 15187503.722op/s 0.29% -0.127 -0.310 0.13% 1389.254op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.622µs 4.632µs ± 0.005µs 4.632µs ± 0.003µs 4.635µs 4.640µs 4.645µs 4.646µs 0.32% 0.422 0.227 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215219077.577op/s 215869576.424op/s ± 210973.390op/s 215909339.669op/s ± 139919.567op/s 215997580.999op/s 216192360.439op/s 216302906.914op/s 216354496.843op/s 0.21% -0.416 0.220 0.10% 14918.071op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.205µs 62.361µs ± 0.074µs 62.346µs ± 0.045µs 62.408µs 62.503µs 62.532µs 62.585µs 0.38% 0.563 -0.024 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15978218.810op/s 16035731.331op/s ± 18994.223op/s 16039430.299op/s ± 11562.117op/s 16049164.272op/s 16062179.994op/s 16069645.627op/s 16075759.362op/s 0.23% -0.557 -0.032 0.12% 1343.094op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.390µs 59.472µs ± 0.034µs 59.469µs ± 0.017µs 59.490µs 59.531µs 59.552µs 59.619µs 0.25% 0.448 1.328 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16773232.937op/s 16814692.513op/s ± 9626.201op/s 16815434.340op/s ± 4942.424op/s 16819932.077op/s 16830807.289op/s 16836664.324op/s 16837851.490op/s 0.13% -0.443 1.315 0.06% 680.675op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 7.234µs 7.246µs ± 0.005µs 7.245µs ± 0.002µs 7.248µs 7.254µs 7.267µs 7.279µs 0.46% 2.218 11.037 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 137382164.453op/s 138004634.501op/s ± 100971.095op/s 138020576.060op/s ± 39465.331op/s 138053745.093op/s 138131363.438op/s 138211884.337op/s 138238473.479op/s 0.16% -2.200 10.924 0.07% 7139.735op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.630µs; 4.632µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ throughput [215884448.153op/s; 215960598.635op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [92.730µs; 92.882µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10766782.482op/s; 10784277.065op/s] or [-0.081%; +0.081%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.890µs; 85.005µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11764460.888op/s; 11780021.007op/s] or [-0.066%; +0.066%] None None None
credit_card/is_card_number/37828224631 execution_time [4.631µs; 4.633µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/37828224631 throughput [215861334.453op/s; 215930837.169op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.013µs; 81.091µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/378282246310005 throughput [12332014.666op/s; 12343859.752op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.477µs; 59.487µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16810301.069op/s; 16813188.122op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [7.245µs; 7.247µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 throughput [137995914.287op/s; 138021783.312op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.632µs; 4.633µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ throughput [215846705.342op/s; 215911261.278op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [74.413µs; 74.447µs] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13432400.403op/s; 13438624.979op/s] or [-0.023%; +0.023%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.020µs; 66.044µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15141488.745op/s; 15146934.522op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.632µs; 4.633µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215840337.541op/s; 215898815.307op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [62.351µs; 62.371µs] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16033098.914op/s; 16038363.748op/s] or [-0.016%; +0.016%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.467µs; 59.477µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16813358.414op/s; 16816026.612op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [7.245µs; 7.247µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [137990640.878op/s; 138018628.123op/s] or [-0.010%; +0.010%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 3c7a240 1733352538 levi/ddcommon-net2
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 297.658ns 310.748ns ± 15.332ns 305.215ns ± 4.408ns 310.079ns 342.956ns 357.600ns 362.157ns 18.66% 1.702 1.834 4.92% 1.084ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [308.623ns; 312.872ns] or [-0.684%; +0.684%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.80562% with 304 lines in your changes missing coverage. Please review.

Project coverage is 70.17%. Comparing base (1cf5035) to head (3c7a240).
Report is 4 commits behind head on levi/split-net.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           levi/split-net     #766      +/-   ##
==================================================
- Coverage           70.55%   70.17%   -0.38%     
==================================================
  Files                 297      300       +3     
  Lines               43547    43849     +302     
==================================================
+ Hits                30726    30773      +47     
- Misses              12821    13076     +255
Components Coverage Δ
crashtracker 44.89% <ø> (ø)
crashtracker-ffi 8.41% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 88.81% <53.84%> (-0.29%) ⬇️
data-pipeline-ffi 0.00% <0.00%> (ø)
ddcommon 75.24% <18.01%> (-8.03%) ⬇️
ddcommon-ffi 68.50% <0.00%> (ø)
ddtelemetry 59.07% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.86% <ø> (ø)
profiling 84.85% <69.86%> (+0.54%) ⬆️
profiling-ffi 77.43% <60.00%> (-0.07%) ⬇️
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 93.47% <ø> (ø)
trace-mini-agent 72.38% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 92.90% <ø> (ø)

dependabot bot and others added 2 commits December 3, 2024 09:13
@dependabot @ivoanjo
Bump rustls from 0.23.16 to 0.23.18 (#773)
e9e4c06 
* Bump rustls from 0.23.16 to 0.23.18

Bumps [rustls](https://github.com/rustls/rustls) from 0.23.16 to 0.23.18.
- [Release notes](https://github.com/rustls/rustls/releases)
- [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md)
- [Commits](rustls/rustls@v/0.23.16...v/0.23.18)

---
updated-dependencies:
- dependency-name: rustls
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update LICENSE-3rdparty.yml with package version bump

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ivo Anjo <[email protected]>
@hoolioh
Fix builder cmake target directory. (#776)
1776e5d 
* Fix cmake target directory.
@ekump
Implement UnderlyingBytes for ByteSlice so it can be borrowed as unde…
a3c1bd4 
…rlying for TinyBytes::Bytes (#764)

Update data-pipeline's send function to accept a tinybytes::Bytes for the payload type. 

Also update the data-pipeline-ffi ddog_trace_exporter_send function to transmute the incoming ByteSlice to static. The ByteSlice is expected to live for the length of the function call, but it is technically possible to borrow the underlying data for longer, leading to stale references. This will be addressed as part of APMSP-1621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
common crashtracker data-pipeline profiling Relates to the profiling* modules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morrisonlevi @codecov-commenter @hoolioh @ekump