-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build instructions for examples/ffi #785
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2024-12-16 14:19:40 Comparing candidate commit 3fa9e66 in PR branch Found 2 performance improvements and 10 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:concentrator/add_spans_to_concentrator
scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/bad-name
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_trace/test_trace
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
+ Coverage 70.59% 70.91% +0.32%
==========================================
Files 296 313 +17
Lines 43246 45751 +2505
==========================================
+ Hits 30528 32444 +1916
- Misses 12718 13307 +589
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
examples/ffi/README.md
Outdated
In order to be able to run FFI examples, you need to build the shared library and headers with the command: | ||
```c | ||
// (dont worry too much about the fact that this is named "profiling") | ||
./build-profiling-ffi.sh ./build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively:
cargo run --bin release --features profiling,telemetry,data-pipeline,symbolizer,crashtracker --release -- --out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, we're working towards removing the scripts so it would be good that people running the examples use the new way to build the project.
examples/ffi/README.md
Outdated
|
||
You can then build the examples with: | ||
|
||
```c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bash?
Should I add the release folder in the .gitignore ? I would say yes but maybe there is a reason for it to not be in it |
What does this PR do?
Add a README with instructions to build and launch the ffi examples
Motivation
I had to ask the commands to build them.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.