Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Refactor receiver code into seperate files. #818

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Splits the code into cleaner files.

Motivation

I want to support the new RFC5 format, and this separates out the code that will need to change.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested a review from a team as a code owner January 10, 2025 20:13
@pr-commenter
Copy link

pr-commenter bot commented Jan 10, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-01-10 21:36:33

Comparing candidate commit 527eae3 in PR branch dsn/crashtracker-split-receiver with baseline commit 014b27e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 76.434µs 76.716µs ± 0.357µs 76.677µs ± 0.041µs 76.724µs 76.785µs 77.630µs 81.377µs 6.13% 11.500 144.245 0.46% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [76.667µs; 76.766µs] or [-0.065%; +0.065%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 57.821ms 58.189ms ± 0.185ms 58.181ms ± 0.104ms 58.274ms 58.478ms 58.773ms 59.340ms 1.99% 1.674 7.438 0.32% 0.013ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.163ms; 58.215ms] or [-0.044%; +0.044%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.614ns 307.030ns ± 12.587ns 301.615ns ± 3.950ns 310.943ns 333.127ns 349.960ns 354.515ns 17.54% 1.831 2.876 4.09% 0.890ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.286ns; 308.775ns] or [-0.568%; +0.568%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.533µs 139.313µs ± 0.328µs 139.272µs ± 0.119µs 139.389µs 139.745µs 140.846µs 141.907µs 1.89% 3.571 22.847 0.23% 0.023µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.267µs; 139.358µs] or [-0.033%; +0.033%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 299.806µs 303.144µs ± 1.044µs 303.084µs ± 0.709µs 303.897µs 304.929µs 305.547µs 305.653µs 0.85% -0.159 0.354 0.34% 0.074µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3271686.282op/s 3298796.111op/s ± 11370.518op/s 3299415.949op/s ± 7730.878op/s 3306240.125op/s 3317420.650op/s 3330276.286op/s 3335491.520op/s 1.09% 0.183 0.381 0.34% 804.017op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.070µs 27.306µs ± 0.110µs 27.294µs ± 0.066µs 27.373µs 27.482µs 27.563µs 27.964µs 2.45% 1.151 5.370 0.40% 0.008µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35760165.764op/s 36622269.955op/s ± 147092.770op/s 36638031.433op/s ± 87973.950op/s 36713841.914op/s 36846319.551op/s 36903610.897op/s 36941107.431op/s 0.83% -1.080 4.932 0.40% 10401.030op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.858µs 15.968µs ± 0.100µs 15.942µs ± 0.030µs 15.976µs 16.277µs 16.317µs 16.330µs 2.43% 2.481 5.775 0.62% 0.007µs 1 200
normalization/normalize_name/normalize_name/good throughput 61238671.494op/s 62627906.976op/s ± 385655.751op/s 62726619.962op/s ± 116122.960op/s 62830341.837op/s 62963278.671op/s 63017238.847op/s 63058003.210op/s 0.53% -2.451 5.654 0.61% 27269.980op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [303.000µs; 303.289µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3297220.266op/s; 3300371.955op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.291µs; 27.321µs] or [-0.056%; +0.056%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36601884.311op/s; 36642655.598op/s] or [-0.056%; +0.056%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.954µs; 15.982µs] or [-0.087%; +0.087%] None None None
normalization/normalize_name/normalize_name/good throughput [62574458.798op/s; 62681355.154op/s] or [-0.085%; +0.085%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.765µs 37.226µs ± 0.734µs 36.900µs ± 0.063µs 36.975µs 38.775µs 38.883µs 40.142µs 8.79% 1.758 1.504 1.97% 0.052µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.125µs; 37.328µs] or [-0.273%; +0.273%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 544.530µs 545.941µs ± 1.206µs 545.576µs ± 0.390µs 546.080µs 548.863µs 550.570µs 551.355µs 1.06% 2.069 4.316 0.22% 0.085µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1813713.899op/s 1831709.045op/s ± 4027.398op/s 1832925.622op/s ± 1312.239op/s 1834099.299op/s 1835373.354op/s 1836276.038op/s 1836447.374op/s 0.19% -2.056 4.246 0.22% 284.780op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 475.206µs 476.004µs ± 0.346µs 475.962µs ± 0.208µs 476.209µs 476.647µs 476.987µs 477.139µs 0.25% 0.606 0.408 0.07% 0.024µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2095824.170op/s 2100822.369op/s ± 1524.357op/s 2101009.341op/s ± 919.494op/s 2101882.795op/s 2102861.248op/s 2103644.462op/s 2104352.632op/s 0.16% -0.602 0.400 0.07% 107.788op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.917µs 195.365µs ± 0.315µs 195.347µs ± 0.107µs 195.448µs 195.639µs 195.705µs 198.553µs 1.64% 6.379 58.375 0.16% 0.022µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5036427.286op/s 5118630.606op/s ± 8161.741op/s 5119098.182op/s ± 2796.855op/s 5121931.971op/s 5128077.065op/s 5130027.770op/s 5130399.222op/s 0.22% -6.285 57.152 0.16% 577.122op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.042µs 47.680µs ± 0.207µs 47.719µs ± 0.138µs 47.820µs 47.966µs 48.145µs 48.205µs 1.02% -0.377 0.169 0.43% 0.015µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20744932.487op/s 20973755.786op/s ± 91265.526op/s 20956186.778op/s ± 60678.333op/s 21037059.984op/s 21132683.119op/s 21208553.692op/s 21257393.298op/s 1.44% 0.403 0.192 0.43% 6453.447op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.885µs 50.205µs ± 0.152µs 50.194µs ± 0.076µs 50.271µs 50.396µs 50.496µs 51.613µs 2.83% 4.073 35.655 0.30% 0.011µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19374990.170op/s 19918615.597op/s ± 59425.852op/s 19922524.817op/s ± 30193.813op/s 19950447.782op/s 19994261.178op/s 20017135.424op/s 20045935.852op/s 0.62% -3.887 33.449 0.30% 4202.042op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [545.774µs; 546.108µs] or [-0.031%; +0.031%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1831150.887op/s; 1832267.204op/s] or [-0.030%; +0.030%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.956µs; 476.052µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2100611.107op/s; 2101033.630op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [195.322µs; 195.409µs] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5117499.467op/s; 5119761.745op/s] or [-0.022%; +0.022%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.651µs; 47.708µs] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20961107.261op/s; 20986404.310op/s] or [-0.060%; +0.060%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.184µs; 50.226µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19910379.746op/s; 19926851.449op/s] or [-0.041%; +0.041%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.385µs 3.305µs ± 1.468µs 3.108µs ± 0.025µs 3.134µs 3.803µs 14.303µs 15.350µs 393.84% 7.438 56.072 44.29% 0.104µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.102µs; 3.509µs] or [-6.154%; +6.154%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.781µs 2.809µs ± 0.020µs 2.804µs ± 0.008µs 2.811µs 2.862µs 2.870µs 2.876µs 2.60% 1.594 2.004 0.72% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.806µs; 2.811µs] or [-0.100%; +0.100%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.905µs 26.985µs ± 13.639µs 18.275µs ± 0.183µs 35.821µs 45.378µs 51.203µs 144.267µs 689.41% 3.865 27.542 50.42% 0.964µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [25.095µs; 28.875µs] or [-7.005%; +7.005%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.323ms 6.339ms ± 0.008ms 6.339ms ± 0.004ms 6.343ms 6.350ms 6.360ms 6.388ms 0.77% 1.943 9.626 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.338ms; 6.340ms] or [-0.018%; +0.018%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 527eae3 1736540038 dsn/crashtracker-split-receiver
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.276µs 4.291µs ± 0.003µs 4.291µs ± 0.001µs 4.292µs 4.295µs 4.298µs 4.319µs 0.64% 2.884 26.888 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 231545933.160op/s 233021363.612op/s ± 180451.583op/s 233022554.954op/s ± 63873.695op/s 233100815.855op/s 233231069.146op/s 233353897.496op/s 233874780.372op/s 0.37% -2.837 26.558 0.08% 12759.854op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 92.498µs 93.490µs ± 0.565µs 93.481µs ± 0.293µs 93.739µs 94.083µs 94.450µs 99.008µs 5.91% 4.605 43.478 0.60% 0.040µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10100205.365op/s 10696676.935op/s ± 63030.024op/s 10697368.460op/s ± 33546.543op/s 10733046.514op/s 10776760.785op/s 10793988.396op/s 10811060.948op/s 1.06% -4.185 38.284 0.59% 4456.896op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 87.276µs 87.983µs ± 0.449µs 87.983µs ± 0.162µs 88.109µs 88.343µs 88.554µs 93.425µs 6.19% 8.929 106.250 0.51% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10703791.170op/s 11366055.827op/s ± 55527.291op/s 11365841.668op/s ± 20862.822op/s 11392174.717op/s 11415198.894op/s 11435621.114op/s 11457926.694op/s 0.81% -8.497 99.438 0.49% 3926.372op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.273µs 4.290µs ± 0.005µs 4.290µs ± 0.002µs 4.292µs 4.294µs 4.295µs 4.345µs 1.29% 7.701 91.684 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230123127.226op/s 233082235.737op/s ± 254673.409op/s 233081202.001op/s ± 90661.099op/s 233180756.335op/s 233325987.906op/s 233415974.052op/s 234011169.290op/s 0.40% -7.588 90.129 0.11% 18008.129op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 84.913µs 85.501µs ± 0.218µs 85.495µs ± 0.144µs 85.639µs 85.876µs 86.014µs 86.117µs 0.73% 0.101 -0.105 0.25% 0.015µs 1 200
credit_card/is_card_number/378282246310005 throughput 11612137.675op/s 11695786.991op/s ± 29771.719op/s 11696629.285op/s ± 19660.753op/s 11716238.561op/s 11742653.525op/s 11762117.291op/s 11776716.254op/s 0.68% -0.087 -0.109 0.25% 2105.178op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.965µs 59.066µs ± 0.037µs 59.059µs ± 0.021µs 59.085µs 59.136µs 59.161µs 59.193µs 0.23% 0.488 1.069 0.06% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16893928.094op/s 16930275.256op/s ± 10538.450op/s 16932180.690op/s ± 5953.651op/s 16936590.253op/s 16945672.936op/s 16956768.075op/s 16959280.767op/s 0.16% -0.482 1.064 0.06% 745.181op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.833µs 6.844µs ± 0.004µs 6.843µs ± 0.002µs 6.846µs 6.851µs 6.854µs 6.856µs 0.18% 0.377 1.135 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145863114.551op/s 146115636.149op/s ± 80560.519op/s 146125249.666op/s ± 43419.080op/s 146167886.916op/s 146214988.502op/s 146334267.989op/s 146349188.363op/s 0.15% -0.372 1.133 0.05% 5696.489op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.277µs 4.292µs ± 0.005µs 4.292µs ± 0.002µs 4.294µs 4.299µs 4.304µs 4.341µs 1.16% 4.257 36.954 0.12% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 230347827.195op/s 232980155.844op/s ± 283544.103op/s 233016486.896op/s ± 106137.668op/s 233115601.262op/s 233305667.112op/s 233397246.659op/s 233806586.886op/s 0.34% -4.182 36.057 0.12% 20049.596op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 70.454µs 71.443µs ± 0.463µs 71.439µs ± 0.283µs 71.721µs 72.247µs 72.646µs 72.807µs 1.92% 0.278 0.076 0.65% 0.033µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13734852.787op/s 13997730.993op/s ± 90634.396op/s 13998005.291op/s ± 55210.479op/s 14052373.599op/s 14145252.393op/s 14176859.548op/s 14193613.665op/s 1.40% -0.240 0.033 0.65% 6408.820op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.298µs 66.215µs ± 0.342µs 66.248µs ± 0.227µs 66.444µs 66.781µs 66.908µs 67.009µs 1.15% -0.192 -0.334 0.52% 0.024µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14923375.877op/s 15102759.916op/s ± 78134.149op/s 15094805.189op/s ± 51754.693op/s 15157098.327op/s 15230517.995op/s 15295238.016op/s 15314521.219op/s 1.46% 0.217 -0.321 0.52% 5524.919op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.276µs 4.292µs ± 0.003µs 4.292µs ± 0.001µs 4.293µs 4.296µs 4.298µs 4.312µs 0.46% 0.889 13.501 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 231931621.265op/s 232987344.233op/s ± 156356.054op/s 233004840.828op/s ± 76301.492op/s 233070312.669op/s 233181605.401op/s 233313396.685op/s 233841347.223op/s 0.36% -0.860 13.413 0.07% 11056.043op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.857µs 63.552µs ± 0.292µs 63.550µs ± 0.221µs 63.754µs 64.016µs 64.143µs 64.382µs 1.31% 0.047 -0.448 0.46% 0.021µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15532251.935op/s 15735589.351op/s ± 72254.833op/s 15735735.269op/s ± 54974.269op/s 15791366.479op/s 15845274.654op/s 15892067.021op/s 15909133.474op/s 1.10% -0.026 -0.458 0.46% 5109.188op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.996µs 59.070µs ± 0.032µs 59.069µs ± 0.017µs 59.088µs 59.123µs 59.167µs 59.173µs 0.18% 0.372 0.840 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16899512.121op/s 16929150.992op/s ± 9100.352op/s 16929387.525op/s ± 4937.775op/s 16934294.092op/s 16944463.335op/s 16949248.307op/s 16950281.434op/s 0.12% -0.368 0.834 0.05% 643.492op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.834µs 6.843µs ± 0.003µs 6.843µs ± 0.002µs 6.845µs 6.848µs 6.852µs 6.859µs 0.24% 0.503 3.370 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145790910.705op/s 146135061.056op/s ± 68893.788op/s 146141682.162op/s ± 36425.720op/s 146170791.422op/s 146251859.505op/s 146302175.991op/s 146320465.639op/s 0.12% -0.496 3.348 0.05% 4871.526op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.291µs; 4.292µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [232996354.758op/s; 233046372.466op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.412µs; 93.569µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10687941.580op/s; 10705412.290op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [87.921µs; 88.046µs] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11358360.279op/s; 11373751.376op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/37828224631 execution_time [4.290µs; 4.291µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [233046940.452op/s; 233117531.022op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.471µs; 85.532µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/378282246310005 throughput [11691660.917op/s; 11699913.065op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.061µs; 59.071µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16928814.728op/s; 16931735.783op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.843µs; 6.844µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [146104471.236op/s; 146126801.062op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.291µs; 4.293µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ throughput [232940859.358op/s; 233019452.329op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [71.379µs; 71.507µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13985169.938op/s; 14010292.049op/s] or [-0.090%; +0.090%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.167µs; 66.262µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15091931.275op/s; 15113588.558op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.292µs; 4.292µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [232965674.788op/s; 233009013.678op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.511µs; 63.592µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15725575.526op/s; 15745603.176op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.065µs; 59.074µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16927889.770op/s; 16930412.213op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.843µs; 6.843µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146125513.040op/s; 146144609.072op/s] or [-0.007%; +0.007%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 44.87179% with 86 lines in your changes missing coverage. Please review.

Project coverage is 71.01%. Comparing base (014b27e) to head (2c6f6d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
- Coverage   71.04%   71.01%   -0.04%     
==========================================
  Files         313      315       +2     
  Lines       45972    45972              
==========================================
- Hits        32659    32645      -14     
- Misses      13313    13327      +14     
Components Coverage Δ
crashtracker 38.52% <44.87%> (ø)
crashtracker-ffi 5.71% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.71% <ø> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 82.08% <ø> (ø)
ddcommon-ffi 65.84% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.91% <ø> (ø)
sidecar-ffi 3.98% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.79% <ø> (ø)

@danielsn danielsn requested a review from a team as a code owner January 10, 2025 21:12
@danielsn danielsn force-pushed the dsn/crashtracker-split-receiver branch from 2c6f6d1 to 527eae3 Compare January 10, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants