Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashtracker] Add incomplete flag to stack traces #819

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

danielsn
Copy link
Contributor

What does this PR do?

Adds an incomplete flag to stack traces, and an RFC explaining why.

Motivation

Sometimes stack traces are incomplete, and the consumer has no way of knowing.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@danielsn danielsn requested review from a team as code owners January 13, 2025 19:59
@pr-commenter
Copy link

pr-commenter bot commented Jan 13, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-01-14 14:18:22

Comparing candidate commit 22095e9 in PR branch dsn/crashtracker-incomplete-stacktrace with baseline commit adc183e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 75.858µs 76.027µs ± 0.279µs 75.996µs ± 0.054µs 76.051µs 76.177µs 76.402µs 79.706µs 4.88% 11.603 149.915 0.37% 0.020µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [75.988µs; 76.066µs] or [-0.051%; +0.051%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 543.619µs 545.712µs ± 2.166µs 545.097µs ± 0.600µs 546.290µs 548.147µs 550.915µs 563.182µs 3.32% 5.140 36.409 0.40% 0.153µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1775625.128op/s 1832496.803op/s ± 7130.385op/s 1834534.610op/s ± 2019.535op/s 1835921.462op/s 1837946.163op/s 1838949.189op/s 1839522.368op/s 0.27% -4.999 34.857 0.39% 504.194op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 475.156µs 476.009µs ± 0.290µs 476.001µs ± 0.157µs 476.157µs 476.441µs 476.672µs 477.900µs 0.40% 1.248 8.367 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2092486.586op/s 2100801.899op/s ± 1276.832op/s 2100835.690op/s ± 692.109op/s 2101541.857op/s 2102584.698op/s 2103897.205op/s 2104573.837op/s 0.18% -1.232 8.262 0.06% 90.286op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 194.369µs 194.959µs ± 0.591µs 194.891µs ± 0.164µs 195.063µs 195.273µs 196.300µs 200.629µs 2.94% 7.750 68.385 0.30% 0.042µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 4984319.724op/s 5129320.122op/s ± 15203.226op/s 5131072.227op/s ± 4307.052op/s 5135188.048op/s 5138747.883op/s 5141827.223op/s 5144853.346op/s 0.27% -7.656 67.206 0.30% 1075.030op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.072µs 47.594µs ± 0.260µs 47.582µs ± 0.120µs 47.695µs 47.882µs 48.079µs 49.688µs 4.43% 4.259 30.760 0.54% 0.018µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20125493.310op/s 21011827.253op/s ± 112098.017op/s 21016490.721op/s ± 53119.229op/s 21071041.015op/s 21138984.960op/s 21171683.542op/s 21243918.546op/s 1.08% -4.025 28.510 0.53% 7926.527op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.817µs 50.136µs ± 0.114µs 50.127µs ± 0.067µs 50.199µs 50.360µs 50.450µs 50.472µs 0.69% 0.433 0.540 0.23% 0.008µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19813131.864op/s 19945876.523op/s ± 45459.849op/s 19949150.802op/s ± 26680.792op/s 19974321.250op/s 20010299.426op/s 20043381.049op/s 20073568.448op/s 0.62% -0.417 0.528 0.23% 3214.497op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [545.412µs; 546.012µs] or [-0.055%; +0.055%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1831508.600op/s; 1833485.006op/s] or [-0.054%; +0.054%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [475.969µs; 476.049µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2100624.942op/s; 2100978.855op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.877µs; 195.041µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5127213.101op/s; 5131427.143op/s] or [-0.041%; +0.041%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.558µs; 47.630µs] or [-0.076%; +0.076%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [20996291.546op/s; 21027362.960op/s] or [-0.074%; +0.074%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.120µs; 50.152µs] or [-0.032%; +0.032%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19939576.226op/s; 19952176.821op/s] or [-0.032%; +0.032%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 58.321ms 58.695ms ± 0.200ms 58.649ms ± 0.073ms 58.746ms 58.992ms 59.471ms 59.756ms 1.89% 2.447 8.574 0.34% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [58.667ms; 58.723ms] or [-0.047%; +0.047%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.275µs 4.292µs ± 0.010µs 4.291µs ± 0.001µs 4.292µs 4.296µs 4.323µs 4.422µs 3.05% 10.840 133.112 0.24% 0.001µs 1 200
credit_card/is_card_number/ throughput 226135282.061op/s 232986483.178op/s ± 538273.103op/s 233043486.954op/s ± 52969.979op/s 233095577.011op/s 233235250.790op/s 233339162.431op/s 233917823.495op/s 0.38% -10.715 130.788 0.23% 38061.656op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 92.472µs 93.597µs ± 0.497µs 93.613µs ± 0.220µs 93.811µs 94.137µs 94.444µs 98.442µs 5.16% 4.489 43.390 0.53% 0.035µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10158225.276op/s 10684381.748op/s ± 55503.174op/s 10682287.166op/s ± 25148.078op/s 10709512.215op/s 10759184.338op/s 10778601.574op/s 10814043.825op/s 1.23% -4.103 38.751 0.52% 3924.667op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 87.452µs 88.030µs ± 0.469µs 87.990µs ± 0.168µs 88.154µs 88.456µs 88.773µs 93.637µs 6.42% 8.630 100.313 0.53% 0.033µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 10679496.051op/s 11360035.389op/s ± 57950.537op/s 11364914.804op/s ± 21745.627op/s 11386905.346op/s 11410769.713op/s 11428769.579op/s 11434820.171op/s 0.62% -8.192 93.359 0.51% 4097.722op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.272µs 4.291µs ± 0.005µs 4.291µs ± 0.001µs 4.292µs 4.295µs 4.296µs 4.346µs 1.30% 8.101 100.309 0.11% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 230074270.264op/s 233039704.047op/s ± 250039.046op/s 233057210.696op/s ± 57112.205op/s 233106054.931op/s 233268900.685op/s 233358222.079op/s 234107693.154op/s 0.45% -7.982 98.758 0.11% 17680.431op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 84.704µs 85.460µs ± 0.194µs 85.460µs ± 0.129µs 85.591µs 85.782µs 85.864µs 85.977µs 0.60% -0.214 0.615 0.23% 0.014µs 1 200
credit_card/is_card_number/378282246310005 throughput 11631006.035op/s 11701495.925op/s ± 26588.597op/s 11701347.412op/s ± 17658.685op/s 11718534.622op/s 11740771.183op/s 11770356.563op/s 11805779.787op/s 0.89% 0.232 0.649 0.23% 1880.098op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.978µs 59.080µs ± 0.038µs 59.074µs ± 0.025µs 59.106µs 59.141µs 59.174µs 59.200µs 0.21% 0.157 0.101 0.06% 0.003µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16892031.204op/s 16926238.268op/s ± 10805.414op/s 16927804.607op/s ± 7194.069op/s 16933269.372op/s 16944631.130op/s 16948953.334op/s 16955610.212op/s 0.16% -0.153 0.099 0.06% 764.058op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.832µs 6.843µs ± 0.004µs 6.842µs ± 0.002µs 6.845µs 6.850µs 6.854µs 6.856µs 0.20% 0.273 0.916 0.06% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 145860888.021op/s 146143819.552op/s ± 88440.770op/s 146151674.951op/s ± 47614.906op/s 146191049.454op/s 146297981.613op/s 146350966.740op/s 146369539.838op/s 0.15% -0.268 0.911 0.06% 6253.707op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.274µs 4.291µs ± 0.002µs 4.291µs ± 0.001µs 4.292µs 4.294µs 4.297µs 4.301µs 0.24% -1.021 11.187 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 232519352.673op/s 233062952.912op/s ± 131592.477op/s 233066531.646op/s ± 61012.374op/s 233124209.952op/s 233241934.741op/s 233360608.260op/s 233959778.791op/s 0.38% 1.042 11.301 0.06% 9304.993op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 70.293µs 71.294µs ± 0.459µs 71.308µs ± 0.279µs 71.560µs 72.043µs 72.463µs 72.732µs 2.00% 0.167 0.048 0.64% 0.032µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13749140.065op/s 14027019.683op/s ± 90125.613op/s 14023753.658op/s ± 54963.307op/s 14083895.654op/s 14176075.075op/s 14207995.715op/s 14226169.058op/s 1.44% -0.128 0.009 0.64% 6372.843op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 65.457µs 66.287µs ± 0.347µs 66.283µs ± 0.251µs 66.537µs 66.842µs 67.047µs 67.127µs 1.27% -0.096 -0.428 0.52% 0.025µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 14897132.341op/s 15086367.507op/s ± 78980.666op/s 15086776.503op/s ± 57201.623op/s 15141755.759op/s 15223958.955op/s 15269256.511op/s 15277294.531op/s 1.26% 0.120 -0.424 0.52% 5584.776op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.272µs 4.291µs ± 0.003µs 4.291µs ± 0.001µs 4.292µs 4.295µs 4.300µs 4.304µs 0.31% -0.638 7.812 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 232318341.707op/s 233047736.925op/s ± 171690.784op/s 233041401.748op/s ± 68893.225op/s 233110728.921op/s 233296283.830op/s 233397100.350op/s 234101274.561op/s 0.45% 0.659 7.892 0.07% 12140.372op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.811µs 63.608µs ± 0.300µs 63.584µs ± 0.215µs 63.842µs 64.109µs 64.299µs 64.391µs 1.27% 0.217 -0.221 0.47% 0.021µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15530169.517op/s 15721739.519op/s ± 74079.929op/s 15727231.673op/s ± 53147.616op/s 15768786.869op/s 15835948.395op/s 15874539.811op/s 15920869.650op/s 1.23% -0.192 -0.224 0.47% 5238.242op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.971µs 59.068µs ± 0.030µs 59.068µs ± 0.017µs 59.086µs 59.119µs 59.132µs 59.142µs 0.13% -0.414 0.688 0.05% 0.002µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16908375.206op/s 16929714.560op/s ± 8683.903op/s 16929532.514op/s ± 4985.529op/s 16934363.677op/s 16945251.671op/s 16953343.804op/s 16957374.248op/s 0.16% 0.418 0.693 0.05% 614.045op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.832µs 6.842µs ± 0.003µs 6.842µs ± 0.001µs 6.844µs 6.847µs 6.850µs 6.863µs 0.30% 0.873 7.642 0.05% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145716919.269op/s 146152198.525op/s ± 70179.510op/s 146156284.656op/s ± 30582.269op/s 146182118.275op/s 146274844.473op/s 146346014.542op/s 146367634.852op/s 0.14% -0.860 7.578 0.05% 4962.441op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.291µs; 4.294µs] or [-0.033%; +0.033%] None None None
credit_card/is_card_number/ throughput [232911883.702op/s; 233061082.653op/s] or [-0.032%; +0.032%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [93.528µs; 93.666µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10676689.542op/s; 10692073.954op/s] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [87.965µs; 88.095µs] or [-0.074%; +0.074%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11352004.002op/s; 11368066.776op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631 execution_time [4.290µs; 4.292µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/37828224631 throughput [233005051.040op/s; 233074357.054op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number/378282246310005 execution_time [85.433µs; 85.486µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/378282246310005 throughput [11697811.001op/s; 11705180.849op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.075µs; 59.085µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16924740.742op/s; 16927735.795op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 throughput [146131562.512op/s; 146156076.592op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.290µs; 4.291µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [233044715.460op/s; 233081190.364op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [71.230µs; 71.357µs] or [-0.089%; +0.089%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14014529.140op/s; 14039510.226op/s] or [-0.089%; +0.089%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [66.239µs; 66.335µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15075421.546op/s; 15097313.468op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.291µs; 4.291µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [233023942.234op/s; 233071531.617op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.566µs; 63.649µs] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15711472.754op/s; 15732006.285op/s] or [-0.065%; +0.065%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.064µs; 59.072µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16928511.055op/s; 16930918.066op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.842µs; 6.843µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146142472.320op/s; 146161924.730op/s] or [-0.007%; +0.007%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 19.262µs 28.856µs ± 14.219µs 19.439µs ± 0.106µs 37.721µs 48.434µs 50.726µs 152.234µs 683.13% 3.917 28.516 49.15% 1.005µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [26.885µs; 30.826µs] or [-6.829%; +6.829%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.423µs 3.344µs ± 1.486µs 3.147µs ± 0.023µs 3.169µs 3.768µs 14.562µs 15.593µs 395.47% 7.448 56.158 44.32% 0.105µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.138µs; 3.550µs] or [-6.158%; +6.158%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 139.024µs 139.727µs ± 0.261µs 139.692µs ± 0.128µs 139.840µs 140.176µs 140.570µs 140.986µs 0.93% 1.222 3.955 0.19% 0.018µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.691µs; 139.763µs] or [-0.026%; +0.026%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 296.595ns 307.718ns ± 14.000ns 300.751ns ± 3.225ns 308.625ns 335.892ns 345.631ns 347.298ns 15.48% 1.335 0.327 4.54% 0.990ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [305.778ns; 309.658ns] or [-0.631%; +0.631%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.780µs 2.807µs ± 0.024µs 2.799µs ± 0.005µs 2.807µs 2.882µs 2.889µs 2.893µs 3.36% 2.578 5.537 0.86% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.804µs; 2.810µs] or [-0.120%; +0.120%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.341ms 6.358ms ± 0.010ms 6.357ms ± 0.004ms 6.362ms 6.372ms 6.377ms 6.457ms 1.56% 4.569 39.649 0.16% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.357ms; 6.360ms] or [-0.023%; +0.023%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.175µs 37.829µs ± 1.088µs 37.337µs ± 0.076µs 37.453µs 40.192µs 40.234µs 40.469µs 8.39% 1.683 0.885 2.87% 0.077µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.678µs; 37.980µs] or [-0.399%; +0.399%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 22095e9 1736863660 dsn/crashtracker-incomplete-stacktrace
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 300.309µs 304.404µs ± 1.558µs 304.599µs ± 0.952µs 305.442µs 306.585µs 307.302µs 307.664µs 1.01% -0.492 -0.182 0.51% 0.110µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3250295.115op/s 3285190.879op/s ± 16862.975op/s 3283007.663op/s ± 10255.071op/s 3295515.301op/s 3316320.103op/s 3327196.800op/s 3329899.837op/s 1.43% 0.517 -0.155 0.51% 1192.392op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.001µs 27.264µs ± 0.086µs 27.262µs ± 0.057µs 27.328µs 27.409µs 27.435µs 27.482µs 0.81% -0.236 0.247 0.31% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 36387403.166op/s 36678655.268op/s ± 115770.759op/s 36681376.491op/s ± 76302.188op/s 36746631.733op/s 36872087.475op/s 37006532.109op/s 37035952.739op/s 0.97% 0.257 0.272 0.31% 8186.229op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.876µs 16.093µs ± 0.160µs 16.013µs ± 0.066µs 16.284µs 16.349µs 16.368µs 16.377µs 2.27% 0.565 -1.432 0.99% 0.011µs 1 200
normalization/normalize_name/normalize_name/good throughput 61062413.549op/s 62143966.571op/s ± 616136.772op/s 62448549.416op/s ± 257670.401op/s 62644966.028op/s 62813241.120op/s 62885282.940op/s 62986241.776op/s 0.86% -0.558 -1.436 0.99% 43567.449op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [304.188µs; 304.620µs] or [-0.071%; +0.071%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3282853.832op/s; 3287527.925op/s] or [-0.071%; +0.071%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.252µs; 27.276µs] or [-0.044%; +0.044%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [36662610.554op/s; 36694699.982op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.071µs; 16.115µs] or [-0.138%; +0.138%] None None None
normalization/normalize_name/normalize_name/good throughput [62058575.940op/s; 62229357.202op/s] or [-0.137%; +0.137%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 7.31707% with 76 lines in your changes missing coverage. Please review.

Project coverage is 70.93%. Comparing base (adc183e) to head (22095e9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #819      +/-   ##
==========================================
- Coverage   71.02%   70.93%   -0.10%     
==========================================
  Files         315      315              
  Lines       45972    46037      +65     
==========================================
+ Hits        32652    32656       +4     
- Misses      13320    13381      +61     
Components Coverage Δ
crashtracker 38.00% <7.31%> (-0.53%) ⬇️
crashtracker-ffi 5.63% <0.00%> (-0.08%) ⬇️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.71% <ø> (ø)
data-pipeline-ffi 90.08% <ø> (ø)
ddcommon 82.08% <ø> (ø)
ddcommon-ffi 65.84% <ø> (ø)
ddtelemetry 59.51% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd 89.59% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.69% <ø> (ø)
profiling 84.29% <ø> (ø)
profiling-ffi 77.55% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.91% <ø> (ø)
sidecar-ffi 3.98% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 93.60% <ø> (ø)
trace-mini-agent 72.48% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.79% <ø> (ø)

Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes a lot of sense--nicely done!

@danielsn danielsn merged commit ccca1d5 into main Jan 14, 2025
31 checks passed
@danielsn danielsn deleted the dsn/crashtracker-incomplete-stacktrace branch January 14, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants