Skip to content

Commit

Permalink
fix test app
Browse files Browse the repository at this point in the history
  • Loading branch information
khanayan123 committed Jan 10, 2025
1 parent 9dfa2a3 commit 6e8f305
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
3 changes: 0 additions & 3 deletions tests/parametric/test_config_consistency.py
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ def test_dd_trace_agent_http_url_nonexistent(self, library_env, test_agent, test
}
],
)
@missing_feature(context.library == "golang", reason="does not support ipv6 urls")
def test_dd_trace_agent_http_url_ipv6(self, library_env, test_agent, test_library):
with test_library as t:
resp = t.config()
Expand All @@ -183,7 +182,6 @@ def test_dd_trace_agent_http_url_ipv6(self, library_env, test_agent, test_librar
assert url.scheme == "http"
assert url.hostname == "::1"
assert url.port == 5000
assert resp["dd_trace_agent_url"] == "http://[::1]:5000"

@parametrize(
"library_env",
Expand All @@ -209,7 +207,6 @@ def test_dd_agent_host_ipv6(self, library_env, test_agent, test_library):
assert url.scheme == "http"
assert url.hostname == "::1"
assert url.port == 5000
assert resp["dd_trace_agent_url"] == "http://[::1]:5000"


@scenarios.parametric
Expand Down
2 changes: 1 addition & 1 deletion utils/build/docker/nodejs/parametric/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ app.get('/trace/config', (req, res) => {
'dd_trace_otel_enabled': 'null', // not exposed in config object in node
'dd_env': config?.tags?.env !== undefined ? `${config.tags.env}` : 'null',
'dd_version': config?.tags?.version !== undefined ? `${config.tags.version}` : 'null',
'dd_trace_agent_url': agentUrl !== undefined ? `${agentUrl.href}` : 'null',
'dd_trace_agent_url': agentUrl !== undefined ? `${agentUrl.origin}` : 'null',
'dd_trace_rate_limit': config?.sampler?.rateLimit !== undefined ? `${config?.sampler?.rateLimit}` : 'null',
'dd_dogstatsd_host': config?.dogstatsd?.hostname !== undefined ? `${config.dogstatsd.hostname}` : 'null',
'dd_dogstatsd_port': config?.dogstatsd?.port !== undefined ? `${config.dogstatsd.port}` : 'null',
Expand Down

0 comments on commit 6e8f305

Please sign in to comment.