Skip to content

Commit

Permalink
[nodejs] Enable DI PII and probe status tests
Browse files Browse the repository at this point in the history
  • Loading branch information
watson committed Jan 13, 2025
1 parent db04b2a commit 8a858f5
Show file tree
Hide file tree
Showing 7 changed files with 62 additions and 45 deletions.
4 changes: 2 additions & 2 deletions manifests/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,11 @@ tests/:
test_debugger_expression_language.py:
Test_Debugger_Expression_Language: missing_feature (feature not implented)
test_debugger_pii.py:
Test_Debugger_PII_Redaction: missing_feature (feature not implented)
Test_Debugger_PII_Redaction: v5.31.0
test_debugger_probe_snapshot.py:
Test_Debugger_Probe_Snaphots: missing_feature (feature not implented)
test_debugger_probe_status.py:
Test_Debugger_Probe_Statuses: missing_feature (feature not implented)
Test_Debugger_Probe_Statuses: v5.31.0
integrations/:
crossed_integrations/:
test_kafka.py:
Expand Down
39 changes: 0 additions & 39 deletions tests/debugger/probes/probe_status_log.json

This file was deleted.

15 changes: 15 additions & 0 deletions tests/debugger/probes/probe_status_log_line.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
[
{
"language": "",
"type": "",
"id": "loga0cf2-line-45cf-9f39-59installed",
"version": 0,
"where": {
"typeName": null,
"sourceFile": "ACTUAL_SOURCE_FILE",
"lines": [
"20"
]
}
}
]
26 changes: 26 additions & 0 deletions tests/debugger/probes/probe_status_log_method.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
[
{
"language": "",
"type": "",
"id": "loga0cf2-meth-45cf-9f39-591received",
"version": 0,
"where": {
"typeName": "NotReallyExists",
"methodName": "SomeMethod",
"sourceFile": null
},
"evaluateAt": "EXIT"
},
{
"language": "",
"type": "",
"id": "loga0cf2-meth-45cf-9f39-59installed",
"version": 0,
"where": {
"typeName": "ACTUAL_TYPE_NAME",
"methodName": "LogProbe",
"sourceFile": null
},
"evaluateAt": "EXIT"
}
]
1 change: 1 addition & 0 deletions tests/debugger/test_debugger_pii.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ def setup_pii_redaction_method_full(self):
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@missing_feature(context.library == "ruby", reason="Local variable capture not implemented for method probes")
@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_pii_redaction_method_full(self):
self._assert(REDACTED_KEYS, REDACTED_TYPES)

Expand Down
1 change: 1 addition & 0 deletions tests/debugger/test_debugger_probe_snapshot.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def _validate_spans(self):
def setup_log_method_probe_snaphots(self):
self._setup("probe_snapshot_log_method", "/debugger/log")

@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_log_method_probe_snaphots(self):
self._assert()
self._validate_snapshots()
Expand Down
21 changes: 17 additions & 4 deletions tests/debugger/test_debugger_probe_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,23 @@ def _check_probe_status(expected_id, expected_status):

assert not errors, f"Probe status errors:\n" + "\n".join(errors)

############ log probe ############
def setup_probe_status_log(self):
self._setup("probe_status_log")
############ log line probe ############
def setup_probe_status_log_line(self):
self._setup("probe_status_log_line")

@bug(context.library == "[email protected]", reason="DEBUG-3127")
@bug(context.library == "[email protected]", reason="DEBUG-3127")
def test_probe_status_log(self):
def test_probe_status_log_line(self):
self._assert()

############ log method probe ############
def setup_probe_status_log_method(self):
self._setup("probe_status_log_method")

@bug(context.library == "[email protected]", reason="DEBUG-3127")
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_probe_status_log_method(self):
self._assert()

############ metric probe ############
Expand All @@ -76,6 +86,7 @@ def setup_probe_status_metric(self):
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@missing_feature(context.library == "ruby", reason="Not yet implemented")
@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_probe_status_metric(self):
self._assert()

Expand All @@ -84,6 +95,7 @@ def setup_probe_status_span(self):
self._setup("probe_status_span")

@missing_feature(context.library == "ruby", reason="Not yet implemented")
@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_probe_status_span(self):
self._assert()

Expand All @@ -94,5 +106,6 @@ def setup_probe_status_spandecoration(self):
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@bug(context.library == "[email protected]", reason="DEBUG-3127")
@missing_feature(context.library == "ruby", reason="Not yet implemented")
@missing_feature(context.library == "nodejs", reason="Not yet implemented")
def test_probe_status_spandecoration(self):
self._assert()

0 comments on commit 8a858f5

Please sign in to comment.