[Tracing] Add tests for proposed new DD_TRACE_PROPAGATION_BEHAVIOR_EXTRACT configuration (APMAPI-1007) #3602
+506
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharycmontoya
force-pushed
the
zach.montoya/poc/propagation-behavior
branch
2 times, most recently
from
59d844f to
8fb956a
Compare
zacharycmontoya
commented
Dec 18, 2024
There was a problem hiding this comment.
This file is only being updated because it also uses the tracing_config_nondefault and tracing_config_nondefault_2 scenarios, which are being co-opted by the new tests. As a result, the implementation details of the tests have been updated while keeping the same high-level goal. cc @mhlidd
mhlidd
reviewed
Dec 20, 2024
…R_EXTRACT configuration
…ndpoint, to return the request and response headers as a dict
… for baggage propagation. - Add another test case with DD_TRACE_PROPAGATION_BEHAVIOR_EXTRACT=restart and DD_TRACE_PROPAGATION_EXTRACT_FIRST=true, where there is always only one span link, which was the valid incoming trace context that got moved to a span link
…dog,tracecontext,b3multi", and update tests/test_distributed.py appropriately
…, W3C Trace Context, B3Multi) and run two test cases per config: Single trace context and multiple trace contexts. This demonstrates how span links will be created in tandem with the ExtractBehavior configurations
…inks represent "terminated contexts" from the incoming context to the final context. Also, make some small assertion fixes
…ssertion updates needed
zacharycmontoya
force-pushed
the
zach.montoya/poc/propagation-behavior
branch
from
de515e6 to
a225dd9
Compare
ZStriker19
approved these changes
Jan 14, 2025
zacharycmontoya
changed the title
zacharycmontoya
changed the title
zacharycmontoya
changed the title
…Conflicting_Contexts_Datadog_Precedence test class
- tests/test_distributed.py::Test_Span_Links_Flags_From_Conflicting_Contexts - tests/test_distributed.py::Test_Span_Links_Omit_Tracestate_From_Conflicting_Contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
I intend to only keep the weblog endpoints as they perform the automatic trace context propagation for supported web frameworks, instead of the parametric test application endpoints which are extremely manual.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present