[nodejs@noop_proxy_name] WIP Try to get TARGET_BRANCH from PR's title #3675
+89
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
p-datadog
reviewed
Dec 16, 2024
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
simon-id
reviewed
Dec 30, 2024
simon-id
reviewed
Dec 30, 2024
simon-id
reviewed
Dec 30, 2024
cbeauchesne
requested changes
Dec 30, 2024
| id: extract | ||
| shell: bash | ||
| run: | | ||
| branch=$(echo "${{ inputs.text }}" | grep -ioP '(?<=\[java|dotnet|python|ruby|php|golang|cpp|agent|nodejs)@.+?\]' | tr -d '[:space:]' || true) |
There was a problem hiding this comment.
Could we limit this to supported lang, and explicitly fail if it's not in the supported list?
I'm 100% someone will try to use one of them, and will struggle to understand why it's not working.
There was a problem hiding this comment.
added assert_target_branch_is_not_set to force fail if the unsupported libs try to specify a target branch
| name: Fail if target branch is specified | ||
| needs: | ||
| - get_dev_artifacts | ||
| if: needs.get_dev_artifacts.outputs.target-branch != '' |
There was a problem hiding this comment.
Did you tested ? I don;t understand where the output of the get_dev_artifacts job is set 🤔
There was a problem hiding this comment.
It's been modified to output the steps.get-target-branch.outputs.target-branch value (lines 66 and 67)
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
iunanua
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Allow testing of tracer branches that are under development by specifying the branch in the PR's title with
[target_language@branch_name_to_test]Changes
get_target_branchgithub action to extract branch from PR's title$TARGET_BRANCHenv var and use it instead the hardcoded "master" branch.system_testsjob name to include target-branch if anyfail-if-target-branchjob which fails if PR title contains a target branch to avoid merging ST PRs without testing the real main/master branchNotes
It is working for cpp, agent, nodejs, ruby and python
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present