Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest and endpoints for the V3 of the appsec login events #3730

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

manuel-alvarez-alvarez
Copy link
Member

@manuel-alvarez-alvarez manuel-alvarez-alvarez commented Dec 19, 2024

Motivation

The new RFC joining all previous documents introduces several updates that we must test in the tracers.

Changes

Enable V3 of the automated login events tests and also update java weblogs to support all the new functionality like the signup events.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/java-ato-v3 branch 3 times, most recently from 986752c to b7055b2 Compare December 20, 2024 09:44
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [Java] update manifest and endpoints for the V3 of the appsect login events [Java] Update manifest and endpoints for the V3 of the appsect login events Dec 20, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [Java] Update manifest and endpoints for the V3 of the appsect login events [Java] Update manifest and endpoints for the V3 of the appsec login events Dec 20, 2024
@manuel-alvarez-alvarez manuel-alvarez-alvarez force-pushed the malvarez/java-ato-v3 branch 3 times, most recently from a91fed2 to 86f64c7 Compare January 3, 2025 08:42
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review January 3, 2025 10:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested review from a team as code owners January 3, 2025 10:47
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title [Java] Update manifest and endpoints for the V3 of the appsec login events Update manifest and endpoints for the V3 of the appsec login events Jan 3, 2025
@manuel-alvarez-alvarez manuel-alvarez-alvarez changed the title Update manifest and endpoints for the V3 of the appsec login events [Java] Update manifest and endpoints for the V3 of the appsec login events Jan 3, 2025
@cbeauchesne
Copy link
Collaborator

Be careful, if any test logic is modified, you must not use any language prefix in PR title. Otherwise, other langs won't be tested, and you take the risk of breaking other repo's CI

@cbeauchesne cbeauchesne changed the title [Java] Update manifest and endpoints for the V3 of the appsec login events Update manifest and endpoints for the V3 of the appsec login events Jan 3, 2025
@manuel-alvarez-alvarez
Copy link
Member Author

Be careful, if any test logic is modified, you must not use any language prefix in PR title. Otherwise, other langs won't be tested, and you take the risk of breaking other repo's CI

Yes, I wasn't sure about it (I did change the title a couple of times). I did update the branch and rerun the tests, the PHP failures seem to be unrelated to this PR.

@robertomonteromiguel
Copy link
Collaborator

Be careful, if any test logic is modified, you must not use any language prefix in PR title. Otherwise, other langs won't be tested, and you take the risk of breaking other repo's CI

Yes, I wasn't sure about it (I did change the title a couple of times). I did update the branch and rerun the tests, the PHP failures seem to be unrelated to this PR.

rebasing the branch...the PHP errors should disappear

@manuel-alvarez-alvarez
Copy link
Member Author

Be careful, if any test logic is modified, you must not use any language prefix in PR title. Otherwise, other langs won't be tested, and you take the risk of breaking other repo's CI

Yes, I wasn't sure about it (I did change the title a couple of times). I did update the branch and rerun the tests, the PHP failures seem to be unrelated to this PR.

rebasing the branch...the PHP errors should disappear

Yep, many thanks, now the PR is green 😄

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 44d73fa into main Jan 7, 2025
433 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/java-ato-v3 branch January 7, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants