Khanayan123/add consistent config system tests

docs/weblog/README.md

@@ -574,6 +574,14 @@ Expected query parameters:
 This endpoint loads a module/package in applicable languages. It's mainly used for telemetry tests to verify that
 the `dependencies-loaded` event is appropriately triggered.
 
+### GET /log/library
+
+This endpoint facilitates the loading of a logging library and logs a specified message. It is primarily designed for testing log injection functionality
+
+The following query parameters are optional:
+- `msg`: Specifies the message to be logged. If not provided, the default message "msg" will be logged.
+- `level`: Specifies the log level to be used. If not provided, the default log level is "info".
+
 ### GET /e2e_single_span
 
 This endpoint will create two spans, a parent span (which is a root-span), and a child span.

manifests/cpp.yml

@@ -241,8 +241,14 @@ tests/:
     Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: missing_feature
     Test_Config_IntegrationEnabled_False: missing_feature
     Test_Config_IntegrationEnabled_True: missing_feature
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: missing_feature
     Test_Config_ObfuscationQueryStringRegexp_Empty: missing_feature
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: missing_feature
     Test_Config_UnifiedServiceTagging_Default: missing_feature
   test_distributed.py:

manifests/dotnet.yml

@@ -488,8 +488,14 @@ tests/:
     Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: v3.5.0
     Test_Config_IntegrationEnabled_False: v3.5.0
     Test_Config_IntegrationEnabled_True: v3.5.0
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: v3.4.1
     Test_Config_ObfuscationQueryStringRegexp_Empty: v3.4.1
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v3.3.0
     Test_Config_UnifiedServiceTagging_Default: v3.3.0
   test_data_integrity.py:

manifests/golang.yml

@@ -589,8 +589,14 @@ tests/:
       uds-echo: missing_feature
     Test_Config_IntegrationEnabled_False: irrelevant (not applicable to Go because of how they do auto instrumentation)
     Test_Config_IntegrationEnabled_True: irrelevant (not applicable to Go because of how they do auto instrumentation)
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: v1.67.0
     Test_Config_ObfuscationQueryStringRegexp_Empty: v1.67.0
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v1.67.0
     Test_Config_UnifiedServiceTagging_Default: v1.67.0
   test_data_integrity.py:

manifests/java.yml

@@ -1648,8 +1648,16 @@ tests/:
     Test_Config_IntegrationEnabled_True:
       '*': irrelevant (kafka endpoints are not implemented)
       spring-boot: v1.42.0
+    Test_Config_IntegrationEnabled_False: irrelevant (not applicable to Go because of how they do auto instrumentation)
+    Test_Config_IntegrationEnabled_True: irrelevant (not applicable to Go because of how they do auto instrumentation)
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: v1.39.0
     Test_Config_ObfuscationQueryStringRegexp_Empty: v1.39.0
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v1.39.0
     Test_Config_UnifiedServiceTagging_Default: v1.39.0
   test_data_integrity.py:

manifests/nodejs.yml

@@ -760,6 +760,8 @@ tests/:
     test_k8s_manual_inject.py:
       TestAdmisionControllerProfiling: *ref_5_22_0
   parametric/:
+    test_128_bit_traceids.py:
+      Test_128_Bit_Traceids: *ref_3_0_0
     test_config_consistency.py:
       Test_Config_Dogstatsd: *ref_5_29_0
       Test_Config_RateLimit: *ref_5_25_0
@@ -849,13 +851,28 @@ tests/:
     Test_Config_IntegrationEnabled_False:
       '*': *ref_5_25_0
       express4-typescript: irrelevant
-      nextjs: irrelevant # nextjs is not related with kafka
+      nextjs: irrelevant
     Test_Config_IntegrationEnabled_True:
       '*': *ref_5_25_0
       express4-typescript: irrelevant
-      nextjs: irrelevant # nextjs is not related with kafka
+      nextjs: irrelevant
+    Test_Config_LogInjection_128Bit_TradeId_Default: missing_feature
+    Test_Config_LogInjection_128Bit_TradeId_Disabled:
+      '*': *ref_3_15_0
+      express4-typescript: irrelevant
+      nextjs: irrelevant
+    Test_Config_LogInjection_Default:
+      '*': *ref_3_0_0
+      express4-typescript: irrelevant
+      nextjs: irrelevant
+    Test_Config_LogInjection_Enabled:
+      '*': *ref_3_0_0
+      express4-typescript: irrelevant
+      nextjs: irrelevant
     Test_Config_ObfuscationQueryStringRegexp_Configured: *ref_3_0_0
     Test_Config_ObfuscationQueryStringRegexp_Empty: *ref_3_0_0
+    Test_Config_RuntimeMetrics_Default: *ref_3_0_0
+    Test_Config_RuntimeMetrics_Enabled: *ref_3_0_0
     Test_Config_UnifiedServiceTagging_CustomService: *ref_5_25_0
     Test_Config_UnifiedServiceTagging_Default: *ref_5_25_0
   test_distributed.py:

manifests/php.yml

@@ -410,8 +410,14 @@ tests/:
     Test_Config_HttpServerErrorStatuses_FeatureFlagCustom: missing_feature
     Test_Config_IntegrationEnabled_False: v1.4.0
     Test_Config_IntegrationEnabled_True: v1.4.0
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: v1.5.0
     Test_Config_ObfuscationQueryStringRegexp_Empty: v1.5.0
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v1.4.0
     Test_Config_UnifiedServiceTagging_Default: v1.4.0
   test_distributed.py:

manifests/python.yml

@@ -896,8 +896,14 @@ tests/:
     Test_Config_IntegrationEnabled_True:
       '*': irrelevant (kafka endpoint is not implemented)
       flask-poc: v2.0.0
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: v2.0.0
     Test_Config_ObfuscationQueryStringRegexp_Empty: v2.15.0
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v2.0.0
     Test_Config_UnifiedServiceTagging_Default: v2.0.0
   test_data_integrity.py:

manifests/ruby.yml

@@ -489,8 +489,14 @@ tests/:
     Test_Config_IntegrationEnabled_True:
       '*': irrelevant (endpoint not implemented)
       rails70: v2.0.0
+    Test_Config_LogInjection_128Bit_TradeId_Default: incomplete_test_app
+    Test_Config_LogInjection_128Bit_TradeId_Disabled: incomplete_test_app
+    Test_Config_LogInjection_Default: incomplete_test_app
+    Test_Config_LogInjection_Enabled: incomplete_test_app
     Test_Config_ObfuscationQueryStringRegexp_Configured: missing_feature
     Test_Config_ObfuscationQueryStringRegexp_Empty: missing_feature (environment variable is not supported)
+    Test_Config_RuntimeMetrics_Default: incomplete_test_app
+    Test_Config_RuntimeMetrics_Enabled: incomplete_test_app
     Test_Config_UnifiedServiceTagging_CustomService: v2.0.0
     Test_Config_UnifiedServiceTagging_Default: v2.0.0
   test_distributed.py:

tests/parametric/test_128_bit_traceids.py

@@ -193,7 +193,6 @@ def test_datadog_128_bit_generation_enabled(self, test_agent, test_library):
 
     @missing_feature(context.library == "golang", reason="not implemented")
     @missing_feature(context.library < "[email protected]", reason="Implemented in 1.24.0")
-    @missing_feature(context.library == "nodejs", reason="not implemented")
     @missing_feature(context.library == "ruby", reason="not implemented")
     @pytest.mark.parametrize("library_env", [{"DD_TRACE_PROPAGATION_STYLE": "Datadog"}])
     def test_datadog_128_bit_generation_enabled_by_default(self, test_agent, test_library):
@@ -409,7 +408,6 @@ def test_w3c_128_bit_propagation_tid_consistent(self, test_agent, test_library):
         assert propagation_error is None
 
     @missing_feature(context.library == "ruby", reason="not implemented")
-    @missing_feature(context.library == "nodejs", reason="not implemented")
     @missing_feature(context.library == "java", reason="not implemented")
     @pytest.mark.parametrize(
         "library_env",

tests/parametric/test_trace_sampling.py

@@ -147,6 +147,75 @@ def test_trace_sampled_by_trace_sampling_rule_glob_match(self, test_agent, test_
         assert span["metrics"].get(SAMPLING_PRIORITY_KEY) == 2
         assert span["metrics"].get(SAMPLING_RULE_PRIORITY_RATE) == 1.0
 
+    @pytest.mark.parametrize(
+        "library_env",
+        [
+            {
+                "DD_TRACE_SAMPLE_RATE": 0,
+                "DD_TRACE_SAMPLING_RULES_FORMAT": "glob",
+                "DD_TRACE_SAMPLING_RULES": json.dumps(
+                    [
+                        {"name": "wEb.rEquEst", "sample_rate": 1},
+                    ]
+                ),
+            },
+            {
+                "DD_TRACE_SAMPLE_RATE": 0,
+                "DD_TRACE_SAMPLING_RULES": json.dumps([{"service": "wEbSerVer", "sample_rate": 1}]),
+            },
+            {
+                "DD_TRACE_SAMPLE_RATE": 0,
+                "DD_TRACE_SAMPLING_RULES_FORMAT": "glob",
+                "DD_TRACE_SAMPLING_RULES": json.dumps([{"resource": "/rAnDom", "sample_rate": 1}]),
+            },
+            {
+                "DD_TRACE_SAMPLE_RATE": 0,
+                "DD_TRACE_SAMPLING_RULES_FORMAT": "glob",
+                "DD_TRACE_SAMPLING_RULES": json.dumps([{"tags": {"key": "vAlUe"}, "sample_rate": 1}]),
+            },
+        ],
+    )
+    @missing_feature(library="cpp", reason="Not implemented")
+    @missing_feature(library="nodejs", reason="Not implemented")
+    def test_field_case_insensitivity(self, test_agent, test_library):
+        """Test span sampling tags are added when a rule with glob patterns with special characters * and ? match"""
+        with test_library:
+            with test_library.dd_start_span(
+                name="web.request", service="webserver", resource="/random", tags=[("key", "value")]
+            ) as span:
+                pass
+
+        span = find_only_span(test_agent.wait_for_num_traces(1))
+
+        assert span["metrics"].get(SAMPLING_PRIORITY_KEY) == 2
+        assert span["metrics"].get(SAMPLING_RULE_PRIORITY_RATE) == 1.0
+
+    @pytest.mark.parametrize(
+        "library_env",
+        [
+            {
+                "DD_TRACE_SAMPLE_RATE": 0,
+                "DD_TRACE_SAMPLING_RULES": json.dumps(
+                    [
+                        {"name": "wEb.*", "sample_rate": 1},
+                    ]
+                ),
+            }
+        ],
+    )
+    def test_trace_sampling_rules_format_not_needed(self, test_agent, test_library):
+        """Glob should work by default without specifying the format"""
+        with test_library:
+            with test_library.dd_start_span(
+                name="web.request", service="webserver", resource="/random", tags=[("key", "value")]
+            ) as span:
+                pass
+
+        span = find_only_span(test_agent.wait_for_num_traces(1))
+
+        assert span["metrics"].get(SAMPLING_PRIORITY_KEY) == 2
+        assert span["metrics"].get(SAMPLING_RULE_PRIORITY_RATE) == 1.0
+
     @pytest.mark.parametrize(
         "library_env",
         [

tests/test_config_consistency.py

@@ -6,6 +6,10 @@
 from utils import weblog, interfaces, scenarios, features, rfc, irrelevant, context, bug, missing_feature
 from utils.tools import logger
 
+# get the default log output
+stdout = interfaces.library_stdout if context.library != "dotnet" else interfaces.library_dotnet_managed
+runtime_metrics = {"nodejs": "runtime.node.mem.heap_total"}
+
 
 @scenarios.default
 @features.tracing_configuration_consistency
@@ -415,3 +419,89 @@ def test_integration_enabled_true(self):
             assert list(
                 filter(lambda span: "kafka.produce" in span.get("name"), spans)
             ), f"No kafka.produce span found in trace: {spans}"
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.tracing_config_nondefault
+@features.tracing_configuration_consistency
+class Test_Config_LogInjection_Enabled:
+    """Verify behavior of integrations automatic spans"""
+
+    def setup_log_injection_enabled(self):
+        self.message = "msg"
+        self.r = weblog.get("/log/library", params={"msg": self.message})
+
+    def test_log_injection_enabled(self):
+        assert self.r.status_code == 200
+        pattern = rf'"dd":\{{"trace_id":"[^"]+","span_id":"\d+","service":"[^"]+","version":"[^"]+","env":"[^"]+"\}},"msg":"{self.message}"'
+        stdout.assert_presence(pattern)
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.tracing_config_nondefault_2
+@features.tracing_configuration_consistency
+class Test_Config_LogInjection_Default:
+    def setup_log_injection_default(self):
+        self.message = "msg"
+        self.r = weblog.get("/log/library", params={"msg": self.message})
+
+    def test_log_injection_default(self):
+        assert self.r.status_code == 200
+        pattern = r'"dd":\{"trace_id":"[^"]+","span_id":"\d+","service":"[^"]+","version":"[^"]+","env":"[^"]+"\},"msg":"^"]+"'
+        stdout.assert_absence(pattern)
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.tracing_config_nondefault
+@features.tracing_configuration_consistency
+class Test_Config_LogInjection_128Bit_TradeId_Default:
+    """Verify 128 bit traceid are enabled in log injection by default"""
+
+    def setup_log_injection_128bit_traceid_default(self):
+        self.message = "msg"
+        self.r = weblog.get("/log/library", params={"msg": self.message})
+
+    def test_log_injection_128bit_traceid_default(self):
+        assert self.r.status_code == 200
+        pattern = r'"dd":\{"trace_id":"[0-9a-f]{32}"'
+        stdout.assert_presence(pattern)
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.tracing_config_nondefault_2
+@features.tracing_configuration_consistency
+class Test_Config_LogInjection_128Bit_TradeId_Disabled:
+    def setup_log_injection_128bit_traceid_disabled(self):
+        self.message = "msg"
+        self.r = weblog.get("/log/library", params={"msg": self.message})
+
+    def test_log_injection_128bit_traceid_disabled(self):
+        assert self.r.status_code == 200
+        pattern = r'"dd":\{"trace_id":"\d+"'
+        stdout.assert_presence(pattern)
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.runtime_metrics_enabled
+@features.tracing_configuration_consistency
+class Test_Config_RuntimeMetrics_Enabled:
+    # This test verifies runtime metrics from the Node.js tracer. It will need to evolve to support assertion on metrics from other tracers
+    def test_config_runtimemetrics_enabled(self):
+        data = list(interfaces.library.get_data("/dogstatsd/v2/proxy"))[0]
+        lines = data["request"]["content"].split("\n")
+        metric_found = False
+        for line in lines:
+            if runtime_metrics["nodejs"] in line:
+                metric_found = True
+                break
+        assert metric_found, f'The metric {runtime_metrics["nodejs"]} was not found in any line'
+
+
+@rfc("https://docs.google.com/document/d/1kI-gTAKghfcwI7YzKhqRv2ExUstcHqADIWA4-TZ387o/edit#heading=h.8v16cioi7qxp")
+@scenarios.tracing_config_nondefault
+@features.tracing_configuration_consistency
+class Test_Config_RuntimeMetrics_Default:
+    # test that by default runtime metrics are disabled
+    def test_config_runtimemetrics_default(self):
+        data = list(interfaces.library.get_data("/dogstatsd/v2/proxy"))
+        assert len(data) == 0

utils/_context/_scenarios/__init__.py

@@ -489,6 +489,7 @@ class _Scenarios:
             "DD_TRACE_KAFKAJS_ENABLED": "false",  # In Node the integration is kafkajs.
             "DD_TRACE_PDO_ENABLED": "false",  # Use PDO for PHP,
             "DD_TRACE_PROPAGATION_STYLE_EXTRACT": "tracecontext,datadog,b3multi",
+            "DD_LOGS_INJECTION": "true",
         },
         appsec_enabled=False,  # disable ASM to test non asm client ip tagging
         iast_enabled=False,
@@ -508,6 +509,8 @@ class _Scenarios:
             "DD_TRACE_CLIENT_IP_HEADER": "custom-ip-header",
             "DD_TRACE_CLIENT_IP_ENABLED": "true",
             "DD_TRACE_PROPAGATION_STYLE_EXTRACT": "datadog,tracecontext,b3multi",
+            "DD_LOGS_INJECTION": "true",
+            "DD_TRACE_128_BIT_TRACEID_LOGGING_ENABLED": "false",
         },
         include_kafka=True,
         include_postgres_db=True,
@@ -781,6 +784,12 @@ class _Scenarios:
     external_processing = ExternalProcessingScenario("EXTERNAL_PROCESSING")
     ipv6 = IPV6Scenario("IPV6")
 
+    runtime_metrics_enabled = EndToEndScenario(
+        "RUNTIME_METRICS_ENABLED",
+        runtime_metrics_enabled=True,
+        doc="Test runtime metrics",
+    )
+
 
 scenarios = _Scenarios()