Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametric: enable XPassing tests [cpp] #3776

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

parametric: enable XPassing tests [cpp] #3776

wants to merge 9 commits into from
+13 −13

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Jan 7, 2025

Motivation

Enable distributed tracing tests for the cpp tracer

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

mabdinur
mabdinur commented Jan 7, 2025
View reviewed changes
binaries/cpp-load-from-git Outdated Show resolved Hide resolved
@mabdinur mabdinur changed the title Munir/enable cpp tests parametric: enable XPassing tests [cpp] Jan 21, 2025
@mabdinur mabdinur force-pushed the munir/enable-cpp-tests branch from b2fd300 to e51c3f7 Compare January 23, 2025 17:41
@mabdinur mabdinur marked this pull request as ready for review January 23, 2025 17:41
@mabdinur mabdinur requested a review from a team as a code owner January 23, 2025 17:41
@mabdinur mabdinur requested review from pablomartinezbernardo and removed request for a team January 23, 2025 17:41
dmehala
dmehala reviewed Jan 24, 2025
View reviewed changes
manifests/cpp.yml Outdated
@@ -148,7 +148,7 @@ tests/:
Test_Otel_Drop_In: missing_feature
parametric/:
test_128_bit_traceids.py:
Test_128_Bit_Traceids: missing_feature (parametric app does not support trace/span/extract endpoint)
Test_128_Bit_Traceids: v1.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next version could be v1.0.1 or v2.0.0 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmehala dmehala dmehala left review comments

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@pablomartinezbernardo pablomartinezbernardo Awaiting requested review from pablomartinezbernardo pablomartinezbernardo is a code owner automatically assigned from DataDog/dd-trace-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mabdinur @dmehala @cbeauchesne