Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parametric] add remote config tests with empty DD_SERVICE or DD_ENV #3778

Merged

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Jan 7, 2025

Motivation

Some tracing libraries added checks for matching service and env in remote config payloads. For example, DataDog/dd-trace-java#6636. This causes issues in scenarios like SSI where the env (aka DD_ENV) is configured in the agent, but not on the tracer. The Java tracer is rejecting remote sampling rules in SSI, which prevents Adaptive Sampling from working correctly.

See also APM_TRACING matching & SSI 🔒

Changes

Add a new test that asserts that the tracing library accepts a remote config payload without checking for matching service or env, since that is already handled by the agent.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel force-pushed the lpimentel/test-remote-config-with-empty-service-env branch from a1df6cb to 890f990 Compare January 8, 2025 19:47
@lucaspimentel lucaspimentel changed the title add remote config tests with empty DD_ENV add remote config tests with empty DD_SERVICE or DD_ENV Jan 8, 2025
@lucaspimentel lucaspimentel force-pushed the lpimentel/test-remote-config-with-empty-service-env branch 3 times, most recently from a86262e to 3a7ada6 Compare January 8, 2025 23:07
@lucaspimentel lucaspimentel changed the title add remote config tests with empty DD_SERVICE or DD_ENV [parametric] add remote config tests with empty DD_SERVICE or DD_ENV Jan 8, 2025
@lucaspimentel lucaspimentel marked this pull request as ready for review January 9, 2025 00:02
@lucaspimentel lucaspimentel requested review from a team and mabdinur as code owners January 9, 2025 00:02
@lucaspimentel lucaspimentel requested review from wconti27, manuel-alvarez-alvarez and sezen-datadog and removed request for a team January 9, 2025 00:02
@lucaspimentel lucaspimentel requested a review from Anilm3 January 9, 2025 00:02
@lucaspimentel lucaspimentel force-pushed the lpimentel/test-remote-config-with-empty-service-env branch from 4184f69 to 5bf407e Compare January 9, 2025 00:20
manifests/php.yml Outdated Show resolved Hide resolved
@lucaspimentel lucaspimentel force-pushed the lpimentel/test-remote-config-with-empty-service-env branch from fbddfa1 to b55074f Compare January 9, 2025 16:09
@lucaspimentel lucaspimentel merged commit 8e61b83 into main Jan 9, 2025
289 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/test-remote-config-with-empty-service-env branch January 9, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants