Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracing] Add test and endpoints to test OTEL Drop-In Support of the OpenTelemetry Propagators API #3782

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zacharycmontoya
Copy link
Contributor

Motivation

We learned that there was an issue with this support in the .NET tracing library, so this new test/endpoint will identify whether other tracers have the same class of issue.

In the .NET scenario, the customer can use the OpenTelemetry Propagators API (implemented in the OpenTelemetry API package) to manually propagate context. When the OpenTelemetry SDK is configured (using the OpenTelemetry SDK package) in the application, the default propagator provided by the OpenTelemetry Propagators API is provided a default implementation, so propagation works as expected. However, when the OpenTelemetry SDK is removed and the user relies on the .NET tracer's OTEL Drop-In Support, the default propagator provided by the OpenTelemetry Propagators API is a no-op, resulting in no propagation happening.

Changes

  • Adds new weblog endpoints:
    • /otel_drop_in_default_propagator_extract
    • /otel_drop_in_default_propagator_inject
  • Adds a new test class Test_Otel_Drop_In_Default_Propagator with test cases:
    • test_propagation_extract
    • test_propagation_inject

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant