Query string obfuscation tests for http client and server spans #3783
+63
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mtoffl01
requested review from
a team,
link04,
mabdinur and
khanayan123
and removed request for
a team
mtoffl01
requested review from
ValentinZakharov,
Mariovido,
PerfectSlayer and
Anilm3
and removed request for
a team
robertomonteromiguel
requested changes
Jan 16, 2025
| self.r = weblog.get("/make_distant_call", params={"url": "http://weblog:7777/?ssn=123-45-6789"}) | ||
|
|
||
| @missing_feature(context.library == "nodejs", reason="Node only obfuscates queries on the server side") | ||
| @missing_feature( |
There was a problem hiding this comment.
why test_query_string_obfuscation_empty_client is marked as irrrelevant and test_query_string_obfuscation_configured_client is marked as missing_feature?
There was a problem hiding this comment.
should be good now
tests/test_config_consistency.py
Outdated
| ) | ||
|
|
||
|
|
||
| @scenarios.default |
There was a problem hiding this comment.
if there is not a @scenarios decorator, it's set as default. No marker needed
robertomonteromiguel
approved these changes
Jan 17, 2025
darccio
approved these changes
Jan 17, 2025
cbeauchesne
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Test that
DD_TRACE_OBFUSCATION_QUERY_STRING_REGEXPapplies to both http client and http server spans.Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present