Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Debugger] remove duplicate entries in java.yml #3784

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Jan 8, 2025

Motivation

Visual Studio Code (probably the YAML extension) showed me these errors when I opened manifests/java.yml :

image

It looks like this happened accidentally during the refactoring in #3616.

Changes

Remove the extra lines.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel added java Pull requests that update Java code run-debugger-scenarios labels Jan 8, 2025
@lucaspimentel lucaspimentel force-pushed the lpimentel/fix-java-yml branch from 4da68a9 to 581017c Compare January 8, 2025 22:32
@lucaspimentel lucaspimentel marked this pull request as ready for review January 8, 2025 23:07
@lucaspimentel lucaspimentel requested review from a team as code owners January 8, 2025 23:07
@lucaspimentel lucaspimentel changed the title [Java][Debugger] remove duplicate entries in java.yml [Java][Debugger] remove duplicate entries in java.yml Jan 8, 2025
@lucaspimentel lucaspimentel merged commit fa9c6e1 into main Jan 9, 2025
52 checks passed
@lucaspimentel lucaspimentel deleted the lpimentel/fix-java-yml branch January 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code run-debugger-scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants