-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nit: Fix spelling of Node.js and .NET #3786
Nit: Fix spelling of Node.js and .NET #3786
Conversation
You know people still have to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No opinion here, as long as each guild is fine with the change, I'm ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Motivation
This isn't that important. But it's a signal about how we treat the two communities. By spelling the name of their language incorrectly, it could be interpreted as not caring/respecting, which obviously we do.
Changes
dotNet
is now spelled.NET
NodeJs
is now spelledNode.js
.Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present