Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes CircleCI job #3792

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Removes CircleCI job #3792

merged 1 commit into from
Jan 9, 2025

Conversation

cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Jan 9, 2025

Motivation

The circleCI job is here the ensure that system-tests works on circleCI

In two years and 9 month, not a single time a bug was found thanks to it (system-tests by design can be executed on any platform supporting docker. turns out this work-by-design is achieved here).

Though it failed numerous times for unrelated reasons. The signal/noise ratio can't be worse.

Changes

Remove CircleCI job

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@cbeauchesne cbeauchesne marked this pull request as ready for review January 9, 2025 17:07
@cbeauchesne cbeauchesne requested a review from a team as a code owner January 9, 2025 17:07
@cbeauchesne cbeauchesne merged commit 07092fa into main Jan 9, 2025
5 of 6 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/circleci branch January 9, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant