Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs for telemetry completeness tests #3794

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Improve docs for telemetry completeness tests #3794

merged 1 commit into from
Jan 9, 2025

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Jan 9, 2025

Motivation

The runbook was missed, so drawing more attention to it

Changes

Update the text for the test failure

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bm1549 bm1549 requested review from a team as code owners January 9, 2025 21:52
@bm1549 bm1549 requested review from pawelchcki and zacharycmontoya and removed request for a team January 9, 2025 21:52
@bm1549 bm1549 merged commit 3d75933 into main Jan 9, 2025
280 of 281 checks passed
@bm1549 bm1549 deleted the bm1549/docs branch January 9, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants