Change Node.js CODEOWNERS to the Node.js guild

[watson]

Motivation

I think the old CODEOWNERS is a legacy setting and that it actually should be the guild(?)

Changes

Change the Node.js CODEOWNERS from @DataDog/apm-js and @DataDog/asm-js to @DataDog/dd-trace-js

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• If PR title starts with [<language>], double-check that only <language> is impacted by the change
• No system-tests internal is modified. Otherwise, I have the approval from R&P team
• CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added (or removed)?
  • Get a review from R&P team

[watson]

• Change Node.js CODEOWNERS to the Node.js guild #3795 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[simon-id]

I think you're right that those two codeowners are obsolete now that more and more teams are using this file, but not sure if dd-trace-js should be the right one. There are a lot of people in that team that would receive emails for every PR and that will probably not care ?
Is there another team that would be more relevant instead ? or should we just keep apm-js, asm-js and add yours ?

[watson]

What members in dd-trace-js shouldn't also be involved in Node.js related system tests in one way or another? Similar to how all members of dd-trace-js should be involved in our regular tests that exists inside the dd-trace-js repo.

[simon-id]

Ok, good point. I just try to not add too much noise to people's info streams