Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex Method for _dev.py #181

Closed
DefinetlyNotAI opened this issue Jan 6, 2025 · 0 comments · Fixed by #182
Closed

Complex Method for _dev.py #181

DefinetlyNotAI opened this issue Jan 6, 2025 · 0 comments · Fixed by #182
Assignees
@DefinetlyNotAI
Labels
request/Minor New feature or request, not important, may not do type/Code Related to the Code part type/Development Related to Development issues

Comments

@DefinetlyNotAI
Copy link
Owner

Code Complexity = 16 - This is too high for method dev_checks()

Source
File
@DefinetlyNotAI DefinetlyNotAI added request/Minor New feature or request, not important, may not do type/Code Related to the Code part type/Development Related to Development issues labels Jan 6, 2025
@DefinetlyNotAI DefinetlyNotAI self-assigned this Jan 6, 2025
DefinetlyNotAI added a commit that referenced this issue Jan 6, 2025
@DefinetlyNotAI
Refactor dev_checks method to reduce complexity
61ebdb8 
Fixes #181

Refactor the `dev_checks()` method in `CODE/_dev.py` to reduce its complexity.

* **Extract User Prompts**: Move the user prompts into a separate method `_perform_checks()`.
* **Handle File Operations**: Create a new method `_handle_file_operations()` to manage file operations and logging.
* **Update Main Method**: Modify the `dev_checks()` method to call `_perform_checks()` and `_handle_file_operations()`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/DefinetlyNotAI/Logicytics/issues/181?shareId=XXXX-XXXX-XXXX-XXXX).
@DefinetlyNotAI DefinetlyNotAI mentioned this issue Jan 6, 2025
Merged
DefinetlyNotAI added a commit that referenced this issue Jan 6, 2025
@DefinetlyNotAI
Refactor dev_checks method to reduce complexity (#182)
a604eed 
Fixes #181

Refactor the `dev_checks()` method in `CODE/_dev.py` to reduce its
complexity.

* **Extract User Prompts**: Move the user prompts into a separate method
`_perform_checks()`.
* **Handle File Operations**: Create a new method
`_handle_file_operations()` to manage file operations and logging.
* **Update Main Method**: Modify the `dev_checks()` method to call
`_perform_checks()` and `_handle_file_operations()`.

---

For more details, open the [Copilot Workspace
session](https://copilot-workspace.githubnext.com/DefinetlyNotAI/Logicytics/pull/182?shareId=6fb8af3c-17b7-4432-a30b-e5d695021c55).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved code structure by separating project guideline checks and
file operations into dedicated functions
- Enhanced modularity and maintainability of development-related
processes

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@github-project-automation github-project-automation bot moved this from Todo to Done in Issue Board Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DefinetlyNotAI DefinetlyNotAI

Labels
request/Minor New feature or request, not important, may not do type/Code Related to the Code part type/Development Related to Development issues
Projects
Issue Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor dev_checks method to reduce complexity DefinetlyNotAI/Logicytics
1 participant
@DefinetlyNotAI