Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a foam sabre #2310

Merged
merged 22 commits into from
Dec 6, 2024
Merged

Add a foam sabre #2310

merged 22 commits into from
Dec 6, 2024

Conversation

Radezolid
Copy link
Contributor

About the PR

Adds a foam sabre, it can spawn in maints and mimes can select to spawn with it.
Also adds a sharp foam sabre, only way to obtain is through the syndicate uplink.

Why / Balance

Fun things for people to play + a stealth weapon, it's damage is equal to the cane blade, same attack rate too.

Technical details

Added YAMLs, sprites and locales.

Media

image
image
image
image

Evil version:
image
image
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

None.

Changelog

🆑

  • add: Added foam sabres! They may appear in maintenance lockers and mimes can select to spawn with it in the loadout selection.
  • add: Added a sharp version of the foam sabre toy, purchasable from the syndicate uplink at 6 TC with a possible discount to 4 TC.

@Radezolid Radezolid requested review from IamVelcroboy and a team as code owners November 28, 2024 17:57
@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi size/M 64-255 lines S: Needs Review labels Nov 28, 2024
Copy link
Contributor

github-actions bot commented Nov 28, 2024

RSI Diff Bot; head commit c971e51 merging into 9ecf70b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/Belt/foamsheath.rsi

State Old New Status
equipped-BELT Added
sheath-sabre-equipped-BELT Added
sheath-sabre Added
sheath Added

Resources/Textures/DeltaV/Objects/Fun/Toys/foam_sabre.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after c971e51

@CybersunOperative
Copy link

Hi. Hello. Val here. The other curators that weighed in on this said they liked it. I do have some minor nitpicks though.
I would highly recommend removing the "It looks sturdier than most." from the evil foam saber description, as that immediately gives it away as le evil valid toy.
You also have an extra period after "A real foam sheathe to cosplay as the captain!"
Otherwise, it seems good. I like the 1% chance for the toy to reflect. Generally a very cute addition to the foam weapon set.

@Radezolid
Copy link
Contributor Author

Radezolid commented Dec 1, 2024

I would highly recommend removing the "It looks sturdier than most." from the evil foam saber description, as that immediately gives it away as le evil valid toy.

That was kind of my intention, a foam weapon being able to do 14 slash kinda feels like it needs to be able to be noticed somehow, it isn't like a stealth pen that it actually hides how it works, the evil version is just a blade with the foam on top as disguise, but sure, I don't really mind changing that.

Regarding the extra period, it's a thing in my native language and sometimes i forgor when writing

@deltanedas
Copy link
Member

description doesnt matter since it has a damage examine compared to foam sabre which doesnt

@Radezolid
Copy link
Contributor Author

Yup, it was flavor text to give a reason for the people to do the "this ones does damage, evil."

deltanedas
deltanedas previously approved these changes Dec 1, 2024
@Monotheonist
Copy link
Contributor

Make sure to add it to the sword mail in mail.yml. Otherwise no one's gonna get the foam sabre in the mail

@Radezolid
Copy link
Contributor Author

Hadn't thought about giving it on the mail, thanks for the idea

@deltanedas deltanedas merged commit 2698e89 into DeltaV-Station:master Dec 6, 2024
16 checks passed
@Radezolid Radezolid deleted the Foam-weaponry branch December 6, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants