Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream merge 12/01/25 #2709

Merged
merged 86 commits into from
Jan 16, 2025
Merged

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Jan 12, 2025

About the PR

  • chameleon pda gaming
  • appraisal tool has a sound, made fake appraisal tool use it :trollface:
  • air alarms have a copy threshold button
  • escape pod directional sign for mapping
  • moved secret weights to SecretDeltaV so upstream changes no longer affect it
  • ghost boo rarely makes vending machines spooky
  • radiator bends for those shitty tegs with 20 radiators in series :trollface:
  • dotnet 9

Media

incredible
08:06:51

Changelog
🆑

  • add: Merged last week's changes from upstream.

Alpaccalypse and others added 30 commits January 12, 2025 07:44
* Corrected all ghost role names to title case.

* Removes full stop from Hamlet's title.

* Updated ghost role names not in the main ghost roles .ftl

* Two capitals corrections
* Renamed "Irish Car Bomb" drink to "Irish Slammer", due to concerns over insensitivity.

* Fixing some missed references

* Added prototype id changes to migration.yml. Removed any reference to the troubles (and corrected ale to stout for flavour text).

* Corrected description back to "Irish Cream"

* Removed non-entities from migration.yml
Make 3.png a PNG
* Remove Undesirable Laws

* empty
* added basic admin logs for PDA notekeeper notes

* formatting

* added new LogType 'PdaInteract' and changed PDA notekeeper logs to it

---------

Co-authored-by: dylanhunter <[email protected]>
…ate computer board sprite. (#34104)

* Defined sprites for non-generic computer boards. Added new syndicate computer board sprite.

* Added new sprite to meta.json and updated attribution.

* Reformatted module.rsi meta.json to match other meta file styles.

* Syndicate board sprite made less yellow/gold, changed outer chips to black. Using grey/silver for CPU centre, akin to syndie agent PDA theme, and to keep distinctive from security board.

* Corrected indentation spacing for currently edited entities.

* Update Resources/Prototypes/Entities/Objects/Devices/Circuitboards/computer.yml

* add pr link to attribution

---------

Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: Errant <[email protected]>
added pricegun sound

Co-authored-by: dylanhunter <[email protected]>
* Update tables.yml

* Remove Extra base: state_

* Update tables.yml
* V1 commit

* Remove PDA name and unnecessary pda state

* Adds PDA to Chameleon backpack & thief toolbox

* Change to use AppearanceDataInit

* Add basic PDA state to ensure there's always a sprite before AppearanceData can be applied

* Revert PDA name (this will be changed to another way later)

* Update PDA name updating to new system

* Fix yaml, and fix Agent ID chameleon

* Updated based on review
* Add some ion storm actions to replace removed ones

* Remove other country references, replace

* Some more tuning of the storm values, removing real-world countries

* boldy basics
* fix rainbow plushie inhands

* address requested changes

* attribute sprites
* refactor wieldable events

* fix inconsitency with wielding and use updated events

* wieldable cosmetic refactoring

* Update Content.Shared/Wieldable/Events.cs

Co-authored-by: Centronias <[email protected]>

* real

Co-authored-by: ScarKy0 <[email protected]>

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Centronias <[email protected]>
Co-authored-by: ScarKy0 <[email protected]>
* lobby name cvar

* panel width

* skrek

* server name localization fix

* comment format fix

Co-authored-by: Thomas <[email protected]>

* remove redundant newline

Co-authored-by: Thomas <[email protected]>

* string.empty

Co-authored-by: Thomas <[email protected]>

* use SetWidth

* Update Resources/Locale/en-US/lobby/lobby-gui.ftl

---------

Co-authored-by: Thomas <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Adds collision with bullets to lights
* Remove kessler, zombeteors gameodes

* Probably should keep the protos in case an admin wants to torture players secretly

* address slart review
@github-actions github-actions bot added the Changes: Audio Changes any audio files label Jan 12, 2025
Copy link
Contributor

github-actions bot commented Jan 12, 2025

RSI Diff Bot; head commit d19a1c1 merging into 7ca7d9c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Effects/fire_greyscale.rsi

State Old New Status
3 Modified

Resources/Textures/Structures/Wallmounts/posters.rsi

State Old New Status
poster53_legit Modified

Resources/Textures/Objects/Fun/toys.rsi

State Old New Status
rainbowlizardplush-inhand-left Added
rainbowlizardplush-inhand-right Added
rainbowlizardplush Added

Resources/Textures/Objects/Misc/module.rsi

State Old New Status
cpu_syndicate Added

Resources/Textures/Structures/Wallmounts/signs.rsi

State Old New Status
direction_pods Added

Edit: diff updated after d19a1c1

@deltanedas deltanedas requested a review from a team as a code owner January 12, 2025 09:01
@IamVelcroboy
Copy link
Member

We'll have to assess how indestructible tiles are used on some of the maps.

@deltanedas
Copy link
Member Author

from what ive seen theyre in the gas miners to prevent miners getting unanchored by anything + to connect ai sats so johnny the techie cant snip the ai off

@Lyndomen
Copy link
Contributor

24 hour direction review time, only thing i see is we might tweak vending machine ops

@IamVelcroboy
Copy link
Member

from what ive seen theyre in the gas miners to prevent miners getting unanchored by anything + to connect ai sats so johnny the techie cant snip the ai off

Yeah, I guess I'm just wondering if using explosives to detach the AI should still be a valid strat since these tiles can't be exploded now?

@Lyndomen
Copy link
Contributor

ok yeah real, only big one we ask is that for now, no indestructible tiles default mapped. if john techie snips ai, skill issue on sec+ai

@Lyndomen Lyndomen self-requested a review January 13, 2025 20:18
@deltanedas
Copy link
Member Author

theyre already unsnippable/rcd/pryable its just now it doesnt get blown up

@CybersunOperative
Copy link

this got approval from direction six hours ago but i forgor :(
anyways its good now!!! :3

@sleepyyapril
Copy link
Contributor

.NET 9 causes this space-wizards/space-station-14#34418

@deltanedas
Copy link
Member Author

its some pc skill issue if anyone has it they can give full logs and specs :trollface:

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 14, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 14, 2025
@sleepyyapril
Copy link
Contributor

its some pc skill issue if anyone has it they can give full logs and specs :trollface:

I have full logs, it doesn't say Anything. It's .NET 9

@deltanedas
Copy link
Member Author

also waiting on space-wizards/RobustToolbox#5607 to be released

@sleepyyapril
Copy link
Contributor

also waiting on space-wizards/RobustToolbox#5607 to be released

released

@deltanedas deltanedas merged commit 5e6d099 into DeltaV-Station:master Jan 16, 2025
14 of 15 checks passed
@deltanedas deltanedas deleted the upstream-ops branch January 16, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: UI Changes: YML Changes any yml files S: Needs Review size/L 256-1023 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.