Accurately find the linux artifacts #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This workflow excludes the build_type matrix when searching for the linux artifact path.
|
I think Linux does not use Debug and Release, correct? So building twice for Linux is redundant? |
|
Release / Debug in cmake also adds But it might be interesting to build with |
For linux in CMakePresets.json unifies all builds, better using this. |
|
This should be ok to squash and merge now. |
Jayman2000
added a commit
to Jayman2000/Descent3-pr
that referenced
this pull request
Apr 21, 2024
2d4d82d (Accurately find the linux artifacts (DescentDevelopers#80), 2024-04-19) made it so that make no longer gets used as a part of the build process, but it didn’t remove make from the list of build dependencies.
JeodC
added a commit
that referenced
this pull request
Apr 28, 2024
use ninja for Linux builds, fixes missing Linux artifacts on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workflow excludes the build_type matrix when searching for the linux artifact path.