another fix for accessing mod details struct + querying tags count #103
Conversation
* fix querying mod tags count * fix mod preview file URI * copy missing mod min/max branches * use different timing for mod update/create/add dates
|
ping @Edremon I'd appreciate if you test your patch on this PR before merging it. |
|
If tags are not specified in mods.json this crash with assertion failed (on tmp.back()). |
* remove spaces between tags (they're comma separated)
|
Will wait until you says it working |
dll/steam_remote_storage.cpp
Outdated
|
|
There was a problem hiding this comment.
Can you drop that change? Would make a useless conflict.
There was a problem hiding this comment.
on my end I don't see the changes nor git detects it since I use LF for everything, can't fix, don't even know what the original line ending was
inside this mess I removed 2 duplicate lines though.
There was a problem hiding this comment.
oh wait I'm an idiot, one moment
There was a problem hiding this comment.
That's a bit annoying because at least locally, it causes a merge conflict when applying #104. It's not a line ending, but some trailing whitespace that got removed. Most files are full of them, and editors will remove them automatically.
There was a problem hiding this comment.
yeah fix already, check above comment
|
I don't think this preview url change anything for Linux, you can have |
|
even if that worked it's better to stick to the standard RFC 8089/3986 in case this is needed later. |
partial fix for #98