Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor fixes #111

Merged
merged 10 commits into from
Dec 7, 2024
Merged

some minor fixes #111

merged 10 commits into from
Dec 7, 2024

Conversation

otavepto
Copy link
Contributor

@otavepto otavepto commented Dec 6, 2024

  • set missing result data in Steam_UGC::SetUserItemVote(), missing boolean vote type (up or down)
  • properly extract inventory item quantity in Steam_Inventory::GetResultItems(), use quantity json property
  • properly implement Steam_Remote_Storage::UpdateUserPublishedItemVote(), update mod details in memory + don't restrict result to current player ID
  • fix implementation of Steam_Remote_Storage::GetUserPublishedItemVoteDetails(), don't restrict result to current player ID
  • minor fix for Steam_User_Stats::FindLeaderboard(), don't use lowercase since later comparison is done case-insensitive, also we have to keep the letter case otherwise some games will hang
  • fix implementation of Steam_UGC::GetItemState(), the mod may be installed but not subscribed
  • missing shutdown in controller
  • missing objects destruction in steam_client + fix destruction order
  • some casting + debug messages + comments
  • remove duplicate helper function common_helpers::ascii_to_lowercase()

@Detanup01 Detanup01 merged commit 9dc32d0 into Detanup01:dev Dec 7, 2024
62 checks passed
@otavepto otavepto deleted the patch-minor-fixes branch December 7, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants