Buffer Device Address in HLSL #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> Use implicit key_t instead of explicit Key template parameter -> Pass workGroupIndex specifically at Counter creation instead of with uniform data -> Remove global memory toroidal access from the histogram shader
| sum = inclusive_scan(val, sdata); | ||
| histogram.atomicAdd(vid, sum); | ||
| if (vid < KeyBucketCount) { | ||
| sum = inclusive_scan(sdata.get(vid), sdata); |
There was a problem hiding this comment.
here's the thing, inclusive_scan uses workgroup barriers, so it needs to be outside of non-uniform control flow
the sdata.get() you can do speculatively (OOB read unlikely to mess up your GPU), its only the atomic add (a write) that needs to be protected against OOB
devshgraphicsprogramming
merged commit 65d5180
into
Devsh-Graphics-Programming:master
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list: