Qual: Fix phan notices

[mdeweerd]

Qual: Fix phan notices

Fix a set of phan notices.

[eldy]

Why removing this else ?

[mdeweerd]

The initial value is now set earlier so that $search_xaxis is always initialized for the static analysis and there is no need to repeat this (and avoids getting a notification that the value was already assigned).

[eldy]

When the customreport.php page is called as a standalone page (not as an include), i do not see at wich line the $search_xaxis is already initialized.
Can you point where the init is done ?

[mdeweerd]

In the "else" branch where this value is not set, we have explicitly this comment:

    // $search_measures, $search_xaxis or $search_yaxis may have been defined by the parent.

It says 'may be', so the code the follows needs to be protected from unset variables.

We can observe this protection:

dolibarr/htdocs/core/customreports.php

Lines 410 to 413 in 28a9552

	} elseif ($mode == 'graph' && isset($search_xaxis) && is_array($search_xaxis) && count($search_xaxis) > 1) {
	setEventMessages($langs->trans("OnlyOneFieldForXAxisIsPossible"), null, 'warnings');
	$search_xaxis = array(0 => $search_xaxis[0]);
	}

dolibarr/htdocs/core/customreports.php

Lines 410 to 413 in 28a9552

	} elseif ($mode == 'graph' && isset($search_xaxis) && is_array($search_xaxis) && count($search_xaxis) > 1) {
	setEventMessages($langs->trans("OnlyOneFieldForXAxisIsPossible"), null, 'warnings');
	$search_xaxis = array(0 => $search_xaxis[0]);
	}

Therefore it is useless to initialize variables to "empty values" that are protected with isset anyway.

In case the protection is unsufficient, the static analysis should kick in and report it.

[eldy]

I think you are right.
It's true. value can be set by parent when the page is called as an include. So should not be erased in this case.
When called as a standalone page, it may be unnitialized but if there is a protection later, we can avoid it to simplify code.
Will wait CTI green to merge with your removal.