feat(global-search): allow global search on services list #32662
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jan 15, 2025
htdocs/contrat/services_list.php
Outdated
| @@ -128,6 +128,19 @@ | |||
|
|
|||
| $search_array_options = $extrafields->getOptionalsFromPost($object->table_element, '', 'search_'); | |||
|
|
|||
| $sall = GETPOST('search_all', 'alphanohtml') ? GETPOST('search_all', 'alphanohtml') : GETPOST('sall', 'alphanohtml'); | |||
There was a problem hiding this comment.
We have abandonned the "sall" in favor of "search_all".
Can you replace variable name and sole remove the GETPOST('sall')...
There was a problem hiding this comment.
@eldy Okay I've been taking care of your suggestions
eldy
added
the
PR to fix - See feedback in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW|New allow global search on services list
I've been added $search_all GETPOST to allow global search on services_list.
I created fieldstosearchall array with default options to search : product label and thirdparty name
I've also added a new hook to complete this array and a new hook to complete FROM sql request