This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
Make GetUserClaims and GetManagementClaims Async #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you currently customizing the user service? I'm asking because we envisioned this API to simply access the claims from the current authentication session, and there are many other ways to enhance the claims in the user's session (ticket store, claims transformation, more middleware, etc). |
|
We're going to reevaluate this request for our next major version, since this would be a breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Addresses DuendeSoftware/products#1702.
Changing to Async makes the implementation easier (IMHO).