Clarify documentation for LicenseUsageSummary parameters. #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated XML documentation to provide detailed descriptions for parameter usage in the LicenseUsageSummary record. This improves clarity, especially for auditing purposes, and ensures better understanding of the fields.
josephdecock
reviewed
Jan 8, 2025
Git might be able to heuristically determine that the files moved if we start this change on the release branch and then try to merge it forward. We still might have merge conflicts, though - sorry! |
|
These changes were merged into the 7.1 release branch, and I have a PR (#1717) to merge everything (including these changes) forward from the release branch to main. I was pleasantly surprised to find that git was able to track the changes even across the file moves! Anyway, I'm closing this in favor of 1717. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
LicenseUsageSummaryclass in theidentity-serverproject. The change improves the documentation by providing more detailed descriptions of the parameters for auditing purposes.Documentation improvements:
identity-server/src/IdentityServer/Licensing/LicenseUsageSummary.cs: Enhanced the documentation comments to include detailed descriptions of theLicenseEdition,ClientsUsed,IssuersUsed, andFeaturesUsedparameters.