EVA-3554 pass application instance id #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitin-ebi
force-pushed
the
pass_application_instance_id
branch
from
8447974 to
1c013f4
Compare
apriltuesday
approved these changes
May 1, 2024
...c/ebi/eva/accession/clustering/configuration/batch/jobs/StudyClusteringJobConfiguration.java
Outdated
Show resolved
Hide resolved
| @@ -19,17 +19,10 @@ | |||
|
|
|||
| public class ApplicationProperties { | |||
|
|
|||
| private String instanceId; | |||
There was a problem hiding this comment.
If submission automation continues to provide this in properties files, will it be ignored? I guess we should remove it from submission automation and assembly ingestion regardless, but it would make production deployment simpler.
There was a problem hiding this comment.
Yes, this will be ignored.
I have tested this locally by leaving the value in properties file and it works fine.
...va/uk/ac/ebi/eva/accession/pipeline/configuration/batch/io/AccessionWriterConfiguration.java
Outdated
Show resolved
Hide resolved
tcezard
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.