EVA-3570 Add jobs for recovering blocks through recovery agent for category ss and rs #447
Conversation
nitin-ebi
force-pushed
the
add-jobs-for-recovery-agent
branch
from
878025c to
e7a4b58
Compare
| clusteredVariantEntityList.add(entity); | ||
| } | ||
|
|
||
| // Entries for 2nd block |
There was a problem hiding this comment.
| // Entries for 2nd block | |
| // Entries for 2nd block -- Missing 6 RS |
| @@ -1,3 +1,4 @@ | |||
| recovery.cutoff.days=14 | |||
There was a problem hiding this comment.
Does it also work to leave the property empty when it's not needed?
There was a problem hiding this comment.
Yes, we don't need to provide this for other jobs.
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| public class MonotonicAccessionRecoveryAgentCategoryRSService { |
There was a problem hiding this comment.
Just because we promised we'd argue about names... what about something shorter like RSAccessionRecoveryService? And analogous naming throughout the other classes.
| VALUES (4, 'test-instance-recover-state-00', 'rs', 3000000090, 3000000089, 3000000119, true, '1970-01-01 00:00:00'); | ||
|
|
||
| INSERT INTO contiguous_id_blocks | ||
| VALUES (5, 'test-instance-recover-state-00', 'rs', 3000000120, 3000000119, 3000000149, true, '2099-01-01 00:00:00'); |
There was a problem hiding this comment.
Can't wait for this test to fail in 2100...
(Just kidding, if the code we write lasts that long I'll be impressed...)
|
|
||
| @Test | ||
| @DirtiesContext | ||
| public void testContiguousBlocksAreReleasedInCaseOfJobFailures() throws Exception { |
There was a problem hiding this comment.
Is this the right test name?
|
|
||
| @Test | ||
| @DirtiesContext | ||
| public void testContiguousBlocksAreReleasedInCaseOfJobFailures() throws Exception { |
There was a problem hiding this comment.
As above - think this test name should be different...
nitin-ebi
force-pushed
the
add-jobs-for-recovery-agent
branch
from
fca29b0 to
7b2780a
Compare
No description provided.