-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pertlim fix for MPAS #1114
base: cam_development
Are you sure you want to change the base?
Pertlim fix for MPAS #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mods are fine. @cacraigucar I was surprised that there aren't pertlim regression tests since ensembles are an important part of climate analysis. I'll bring that up in our SE meeting and see if we need an issue to provide testing for all supported dycores. Since we don't have testing currently in place please run your own test to make sure that the pertlim namelist addition is working correctly and document this in your Changelog.
@patcal - Could you please provide a test that you ran with this new pertlim that we can use as a basis of a CAM regression test? |
The test I ran was for a user-defined MPAS grid and user-generated input
files, so I don't think it is feasible for a standard regression test. I
have not checked
to see if there is a functional implementation of a uniform low-res MPAS
grid in
the current tag. If there is, then I can set up a test using it.
…On Tue, Aug 13, 2024 at 10:57 AM cacraigucar ***@***.***> wrote:
@patcal <https://github.com/patcal> - Could you please provide a test
that you ran with this new pertlim that we can use as a basis of a CAM
regression test?
—
Reply to this email directly, view it on GitHub
<#1114 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJMQHAKRAGN2X5MNFWARLX3ZRI3HPAVCNFSM6AAAAABLVDTAN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBWG4YDKOJSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@patcal - Have you made any progress on creating a regression test? This PR is stalled until we get one made |
Closes #1109