Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated statistical operators #2553

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

schlunma
Copy link
Contributor

Description

This PR removes deprecated statistical operators that have been deprecated in v2.10.0 and are scheduled for removal in v2.12.0. See #2191 for details.

Backwards-incompatible changes

  • Operator pXX.YY to specify percentiles for the multi-model statistics preprocessors: please use statistics: [{operator: percentile, percent: XX.YY}] instead; this is an exact replacement. The following example shows how to modify existing recipes:

Old:

  preprocessors:
    mm_stats:
      multi_model_statistics:
        span: overlap
        statistics: [p5, p95]

New:

  preprocessors:
    mm_stats:
      multi_model_statistics:
        span: overlap
        statistics:
          - operator: percentile
            percent: 5
          - operator: percentile
            percent: 95
  • Option std: please use std_dev instead; this is an exact replacement. Example:

Old:

  preprocessors:
    test:
      zonal_statistics:
        operator: std

New:

  preprocessors:
    test:
      zonal_statistics:
        operator: std_dev

The old syntax will be deprecated with version 2.10 and removed with version 2.12.


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added this to the v2.12.0 milestone Oct 11, 2024
@schlunma schlunma self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (892d4a3) to head (625d53c).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2553      +/-   ##
==========================================
- Coverage   94.92%   94.91%   -0.01%     
==========================================
  Files         251      251              
  Lines       14274    14261      -13     
==========================================
- Hits        13549    13536      -13     
  Misses        725      725              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and cheers, again, Manu 🍺

@valeriupredoi valeriupredoi merged commit da3440e into main Oct 11, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the remove_deprecated_statistical_operators branch October 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants