Monotonicity fixes for Fgoals #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2603 +/- ##
=======================================
Coverage 94.68% 94.69%
=======================================
Files 251 251
Lines 14372 14399 +27
=======================================
+ Hits 13608 13635 +27
Misses 764 764 ☔ View full report in Codecov by Sentry. |
valeriupredoi
approved these changes
Dec 3, 2024
| @@ -507,7 +507,7 @@ def test_pr_fix_metadata(pr_cubes): | |||
|
|
|||
| out_cubes = fix.fix_metadata(pr_cubes) | |||
| for cube in out_cubes: | |||
| if cube.var_name == "tas": | |||
| if cube.var_name == "pr": | |||
There was a problem hiding this comment.
ah snap, cheers for spotting this 😀
|
many thanks @Karen-A-Garcia 🍻 |
valeriupredoi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up for #2602. This is pretty much the same fix and tests I had created for CESM2 from NCAR in #2574 and also I found a slight typo from my last pull request. This should fix the monotonicity issue but I could not figure out where the frequency issue is coming from.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.