-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe changes for new statistics preprocessors (percentiles) #3351
Conversation
@schlunma, could you please comment on the status of this PR? It looks fine to me, but I am not sure if you wanted to add other recipe changes or if it is in draft state simply due to the awaited core release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just merge this as is and then more changes can be added later.
Yes, this PR was ready from my side. Thanks for merging it! I noticed that since opening this PR another recipe has been added in #3356 that uses the deprecated syntax. @bouweandela, since you are the author of that recipe, would you be able to adapt the recipe and the diagnostics to the new syntax? Thanks!! |
Co-authored-by: Klaus Zimmermann <[email protected]>
Description
This PR adapts recipes in light of ESMValGroup/ESMValCore#2191. Needs a new ESMValCore release to work. The output of the new recipes is identical with the old versions.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: