Feature: admin-tools-specific subcommands (Ref: #40)
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirtangajjar
suggested changes
Sep 21, 2021
Earlier, we used admin_tools_create_auth() to create auth specifically for default_admin_tools
it created a lot of redundant code. We are able to replicate the same by adding an else if {}
in populate_info() method.
Remove all admin_tools_ prefixed functions. Functionality was replaced by modifying populate_info() method.
kirtangajjar
suggested changes
Sep 22, 2021
|
@danish17 Please also checkout requested changes |
`ee auth delete global` had unexpected behaviour, it works expectedly now. `ee auth list global` showed admin-tools auth, it will exclusively show default auths now.
Changelog: - separated logic for generate_global_auth_files() for default and default_admin_tools - add generate_default_auth_files() to handle generation of default (global) auths
Fix: global auths not working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ Added
admin-toolsspecific support foree authcommand.🔃 Change
generate_global_auth_files()logic🔃 Fix some PHPCS issues
Subcommands 🔧
1. Creating
admin-toolsauth userCreates a new user to be used on
<site_name>/ee-adminSyntax:
ee auth create admin-toolsParameters:
--userusername--passpassword (optional)Example:
ee auth create admin-tools --user=test --pass=test2. Deleting
admin-toolsauth userDeletes an user from
admin-toolsSyntax:
ee auth delete admin-toolsParameters:
--userusernameExample:
ee auth create admin-tools --user=test3. Updating
admin-toolsauth userUpdates an existing user on
admin-toolsSyntax:
ee auth update admin-toolsParameters:
--userusername to update--passnew password (optional)Example:
ee auth update admin-tools --user=test --pass=updatedtest4. Listing
admin-toolsauthLists existing users on
admin-toolsSyntax:
ee auth list admin-toolsExample:
ee auth list admin-toolsFunctions to watch out for 👀
admin_tools_create_auth()admin_tools_update_auth()admin_tools_delete_auth()admin_tools_list_auth()generate_global_auth_files()Footnotes:
Reference: #40