Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update japanese voices #102

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ToshihiroMakuuchi
Copy link
Contributor

Update japanese voices

@pfeerick
Copy link
Member

Thanks for this!

Just out of curiosity... did the numbers 7, 10, 30 not translate properly when in numerical form?

@ToshihiroMakuuchi
Copy link
Contributor Author

ToshihiroMakuuchi commented Feb 16, 2024

Just out of curiosity... did the numbers 7, 10, 30 not translate properly when in numerical form?

Using Azure AI Speech, I corrected it by applying a different string in Japanese, because the pronunciation is obviously wrong. The intonation is different when pronounced alone and when used with other words.

@pfeerick pfeerick merged commit fd74546 into EdgeTX:main Feb 27, 2024
1 check passed
@pfeerick
Copy link
Member

Sorry for the delay! :)

@ToshihiroMakuuchi ToshihiroMakuuchi deleted the ToshihiroMakuuchi/jp-fix01 branch March 17, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants