ESIP SEM-Harmo Cryohackathon sessions Feb - April 2021

[kaiiam]

As part of the ongoing work of the ESIP Semantic harmonization cluster's Global Cryosphere Watch (GCW) cryohackaton work over the period of February - April 2021, we @pbuttigieg @rduerr @brandonnodnarb and others worked on the following term set shown in the second sheet of this ESIP_Cryo_hackathon_robot_template for addition into ENVO, as well as mapping to SWEET. These contributions we conducted following the ENVO Robot template and merge workflow created during the course of this and subsequent work. This issue is to document this work and create a new pull request to merge the contributions into ENVO.

[kaiiam]

Action items to fix for this pull request in addition to the template which are expressed in Editor notes:

Ontology ID	editors note
ENVO:01000818	obsolete this term. Replace by new term for planetary cryosphere.
ENVO:03000143	Make an axiom with composed primarily of frozen environmental materials.
ENVO:03000144	Replacement for ENVO:01000818
ENVO:00000484	Remove old definition: "Any enclosed water area in pack ice other than a lead ..." Remove old superclass lentic water body
ENVO:03000141	1) Add an axioms about A cryospheric layer which is primarily composed of snow. 2) Make a thickness of snow class using the Entity attribute DOSDP. thickness and inheres in some cryospheric layer. That class refers to GCW snow cover definition 3: The depth of snow on the ground, usually expressed in inches or centimeters. Link depth of snow to http://sweetontology.net/propSpaceThickness/SnowCover 3) We might want to make 3 class for ice cover which replicate the patterns used here for the GCW snow cover. Classes such as 1) Area of ice cover 2) ice layer 3) Depth of ice.
ENVO:03000116	Given that SWEET considers the term to be a thickness and ENVO currently considers it a mass of snow; I think we have a fundamental mismatch here. See ESIPFed/sweet#236 (comment).
ENVO:09200020	Make sure to make the DOSDP target for this term: https://github.com/EnvironmentOntology/envo/blob/master/src/envo/modules/entity_attribute.csv#L18
ENVO:01000896	This term exists, we're revising the definition with ESIP semantic Harmonization group, delete the old one. Consider adding axioms like PATO:"decreased temperature" to this and other cold forms of precipitation, such that we can create a grouping class to be filled by inference (with hail, sleet, snow, freezing rain). Something like precipitation below the liquid-solid phase transition point of water.
ENVO:3400007	Add axioms to nest the lake-effect snowfall process in this one
ENVO:00000429	Remove old definition "A thin, almost knife-like, ridge of rock which ..."

[kaiiam]

Doing this locally in a new PR which is called issue-1160, will push it once we resolve some of the above issues.

[kaiiam]

I've addressed all but the following of the above items, the remaining issues need to be addressed:

ENVO:03000143
ENVO:03000141
ENVO:03000116 (just consider maybe no action item)
ENVO:01000896 (maybe add axioms) 
ENVO:3400007 (unclear what needs to be done)

[kaiiam]

Only ENVO:03000141 remaining now. Last steps now to add classes for 1) Area of ice cover 2) ice layer 3) Depth of ice.

[kaiiam]

I see there are some more build errors a duplicated def and some others I'll fix this later.

[kaiiam]

Build is passing and ready for review see #1172.

[kaiiam]

This has been dealt with PR submitted and merged into the main branch. I think we can close this issue. It has the SWEET label to refer to our ESIP Semantic harmonization work.