Issue 1160

[kaiiam]

@pbuttigieg @rduerr PR addressing #1160 last batch of cryospheric work.

[kaiiam]

Build is now passing and ready to merge @pbuttigieg @rduerr @wiegandn please have a look or let me know if we're good to merge!

[rduerr]

@kaiiam I'd love to review this but if you have suggestions for exactly how I should go about doing that, that would be helpful. I have loaded what I think is the #1172 branch of envo-edit into protege and it at least is fine per elk; and I did look at the diff files though the last two seem very opaque to me since I couldn't even find those terms in the envo-edit file. However, it isn't clear how to validate each of the changes made, unless it is by looking at each individual commit and the terms in each in protege? Is that what I am supposed to do? If so, then don't expect something real soon.... since that will take hours....

[kaiiam]

@rduerr I agree reviewing OWL on github can be a pain. However, this PR comes from sheet 2 of ESIP_Cryo_hackathon_robot_template, hence we have the list of IDs added. Its 24 long so I think that's reasonable to double check. One can simply copy these IDs and then in protege with the branch's envo-edit.owl file loaded hit control (or cmd on mac) + F. Then paste the id in the search box then hit enter. That'll take you to the term.

I've checked them and think it's correct with what we put in the robot template (with all the mistakes I found fixed). If there is anything from #1291 you'd like to change please let me know and I can update this PR, otherwise I'd say to just check for obvious errors/mistakes so we can merge these changes in.

ENVO:03000143
ENVO:03000144
ENVO:00000484
ENVO:03000141
ENVO:03000145
ENVO:03000142
ENVO:03000116
ENVO:03400003
ENVO:09200020
ENVO:01000896
ENVO:03400010
ENVO:03400011
ENVO:03400012
ENVO:03400013
ENVO:01000895
ENVO:01000880
ENVO:03400004
ENVO:03400005
ENVO:01000882
ENVO:03400006
ENVO:03400007
ENVO:03400008
ENVO:03400009
ENVO:00000429

[kaiiam]

@pbuttigieg @rduerr and I will pick this up again next week from ENVO:03400012.

[kaiiam]

I'd like to fold addressing the issues in #1069 into this PR, upon urgent request from @matentzn, fixing ENVO_01001784 (which chris suggests to remove the EQ axiom) comparing against ENVO_01001479.

[pbuttigieg]

fixing some reasoner errors detected by hermit

fossil fuel and and biological pigment are roles in CHEBI, not material entities.

@matentzn of interest to you and @laurenechan