Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update envo-idranges.owl #1512

Conversation

turbomam
Copy link
Contributor

removed extra idrange:26,converted to ttl in protege and then converted back to Manchester

removed extra idrange:26,converted to ttl in protege and then converted back to Manchester
@turbomam turbomam requested review from cmungall and pbuttigieg March 13, 2024 15:59
@turbomam turbomam linked an issue Mar 13, 2024 that may be closed by this pull request
less whitespace
annotations and AP declaration order
inter Datatype spacing
@pbuttigieg
Copy link
Member

thanks @turbomam - looks better. Could you confirm the ranges matched to the IDs were double checked ? Range 26 ?

pbuttigieg
pbuttigieg previously approved these changes Mar 13, 2024
@turbomam
Copy link
Contributor Author

turbomam commented Mar 14, 2024

Double checking now. First of all:

  • Alicia Clum's range (3600100 to 3604999) overlaps with the National Microbiome Data Collaborative's range (3600000 to 3609999).
  • Mark Andrew Miller's range (3605000 to 3609999) is completely within the National Microbiome Data Collaborative's range (3600000 to 3609999).

@turbomam
Copy link
Contributor Author

turbomam commented Mar 14, 2024

I will change those now to

  • National Microbiome Data Collaborative: 3600000 to 3600099
  • Alicia Clum: 3600100 to 3604999
  • Mark Andrew Miller: 3605000 to 3619999

@turbomam
Copy link
Contributor Author

I introduced the error in 9837825

@turbomam
Copy link
Contributor Author

@pbuttigieg The mangled ID range 26 overlapped with the NMDC and "Mark Andrew Miller" ranges. I recognize all classes in those two ranges as being requested by/contributed by NMDC and GOLD

I introduced the error in 9837825

I don't see any classes that use the IDs reserved for range 26

This PR is ready for re-review and then merging and releasing in my opinion

@turbomam turbomam requested a review from pbuttigieg March 14, 2024 17:12
@pbuttigieg
Copy link
Member

Sure - I approved already. The file doesn't do anything yet (I think Protégé is / was supposed to develop functionality for that, but it's been on ice for years). As long as the ranges are intact we can merge .

@pbuttigieg pbuttigieg merged commit cee54a7 into master Mar 14, 2024
2 checks passed
@pbuttigieg pbuttigieg deleted the 1511-idrange26-in-srcenvoenvo-idrangesowl-appears-to-be-mangled branch March 14, 2024 17:17
@turbomam
Copy link
Contributor Author

turbomam commented Mar 14, 2024

Thanks

The file doesn't do anything yet (I think Protégé is / was supposed to develop functionality for that, but it's been on ice for years). As long as the ranges are intact we can merge .

When the file isn't corrupted, it certainly does do something! I get a dialog that says "No Id Range Found For Current User...Please select the Id range that you wish to use"

That's because my range is owned by "Mark Andrew Miller" and my OS username is mark

@cmungall
Copy link
Member

https://oboacademy.github.io/obook/howto/idrange/#protege-56

This Protege version looks at the ID range file and matches your user name in Protege to the names in the file to automatically set up your ID range. Thus as long as this information matches you no longer need to manually set the ID range. You will get a message if your user name does not match one in the file asking you to pick an ID range.

Note you can set this under Preferences/User Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idrange:26 in src/envo/envo-idranges.owl appears to be mangled
3 participants