-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update envo-idranges.owl #1512
Update envo-idranges.owl #1512
Conversation
removed extra idrange:26,converted to ttl in protege and then converted back to Manchester
less whitespace
prefix order
annotations and AP declaration order
inter Datatype spacing
pretty similar
thanks @turbomam - looks better. Could you confirm the ranges matched to the IDs were double checked ? Range 26 ? |
Double checking now. First of all:
|
I will change those now to
|
I introduced the error in 9837825 |
@pbuttigieg The mangled ID range 26 overlapped with the NMDC and "Mark Andrew Miller" ranges. I recognize all classes in those two ranges as being requested by/contributed by NMDC and GOLD I introduced the error in 9837825 I don't see any classes that use the IDs reserved for range 26 This PR is ready for re-review and then merging and releasing in my opinion |
Sure - I approved already. The file doesn't do anything yet (I think Protégé is / was supposed to develop functionality for that, but it's been on ice for years). As long as the ranges are intact we can merge . |
Thanks
When the file isn't corrupted, it certainly does do something! I get a dialog that says "No Id Range Found For Current User...Please select the Id range that you wish to use" That's because my range is owned by "Mark Andrew Miller" and my OS username is |
https://oboacademy.github.io/obook/howto/idrange/#protege-56 This Protege version looks at the ID range file and matches your user name in Protege to the names in the file to automatically set up your ID range. Thus as long as this information matches you no longer need to manually set the ID range. You will get a message if your user name does not match one in the file asking you to pick an ID range. Note you can set this under Preferences/User Details |
removed extra idrange:26,converted to ttl in protege and then converted back to Manchester