Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cloneDeep in persistedQueue #55099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Use cloneDeep in persistedQueue #55099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15dc1c4
Use cloneDeep
mountiny Jan 10, 2025
34f795d
Prettier
mountiny Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/libs/actions/PersistedRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import cloneDeep from 'lodash/cloneDeep';
import isEqual from 'lodash/isEqual';
import Onyx from 'react-native-onyx';
import Log from '@libs/Log';
Expand Down Expand Up @@ -60,7 +61,7 @@ function endRequestAndRemoveFromQueue(requestToRemove: Request) {
* We only remove the first matching request because the order of requests matters.
* If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
*/
const requests = [...persistedRequests];
const requests = cloneDeep(persistedRequests);
const index = requests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));

if (index !== -1) {
Expand Down
Loading