chore: type definitions #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshinongit
force-pushed
the
chore-connection-type-definition
branch
from
adcde80 to
13f1883
Compare
birme
requested changes
Dec 19, 2023
src/smb.ts
Outdated
| id: string; | ||
| content: string; | ||
| } | ||
| type SmbEndpointDescription = Static<typeof SmbEndpointDescription>; |
There was a problem hiding this comment.
I would suggest to move the static typedef to the models.ts as well. Then they are all stored at the same place
src/production_manager.ts
Outdated
|
|
||
| type NewProduction = Static<typeof NewProduction>; | ||
| type Production = Static<typeof Production>; | ||
| type Line = Static<typeof Line>; | ||
| type SmbEndpointDescription = Static<typeof SmbEndpointDescription>; |
There was a problem hiding this comment.
Propose to move these static typedef to models.ts
src/production_manager.test.ts
Outdated
|
|
||
| type NewProduction = Static<typeof NewProduction>; | ||
| type Production = Static<typeof Production>; | ||
| type SmbEndpointDescription = Static<typeof SmbEndpointDescription>; |
There was a problem hiding this comment.
Propose to move these to models.ts instead.
src/api_productions.ts
Outdated
| @@ -12,6 +18,8 @@ dotenv.config(); | |||
| type NewProduction = Static<typeof NewProduction>; | |||
| type Production = Static<typeof Production>; | |||
| type Line = Static<typeof Line>; | |||
| type SmbEndpointDescription = Static<typeof SmbEndpointDescription>; | |||
There was a problem hiding this comment.
Move the static typedef to models.ts to avoid having duplicated code.
oshinongit
force-pushed
the
chore-connection-type-definition
branch
from
13f1883 to
0b0f00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New complete type definitions
Cleaned up unused types
Rearranged types towards models.ts