chore: improved docs and removed bad code #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oshinongit
commented
Mar 18, 2024
•
oshinongit
commented
- Improved swagger api docs.
- Adjusted variables received from api request to match the naming convention.
- Fixed incorrect error message.
- Removed unnecessary class inheritance.
oshinongit
force-pushed
the
feat-docs-improved-and-cleanup
branch
from
0674458 to
0d7b319
Compare
oshinongit
force-pushed
the
feat-docs-improved-and-cleanup
branch
from
0d7b319 to
4248fab
Compare
martinstark
approved these changes
Mar 19, 2024
| { | ||
| schema: { | ||
| // description: 'Retrieves an active Production line.', | ||
| description: 'Retrieves an active Production line.', |
There was a problem hiding this comment.
what does it mean that it's active, can the request fail if a line on a production is "inactive"?
There was a problem hiding this comment.
Resolved in meeting.
*Line objects can be saved in the service manager memory but not have connection resources allocated in the SMB instance. These are inactive etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.